Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of tasks not filtered until restart #92

Closed
jsedanoj opened this issue Apr 17, 2020 · 1 comment
Closed

List of tasks not filtered until restart #92

jsedanoj opened this issue Apr 17, 2020 · 1 comment
Labels
bug Something isn't working completed

Comments

@jsedanoj
Copy link

Hi,

I have found what seems to be a bug. I have a PHP project developed in VSCode 1.44.1 (using Remote Containers [https://code.visualstudio.com/docs/remote/containers]), and using Makefile for the build process. So Task Explorer looks ideal (and it is!). Task Explorer 1.26.3.

The project is open source and can be use for testing the bug here: https://gitlab.com/javier.sedano/vaca/-/tree/master

I have configured Task Explorer to exclude vendor/ and bin/.phpunit because they contain some Makefiles and ant files in a workspace .vscode/settings.json:

{
    "taskExplorer.enableAnsiconForAnt": false,
    "taskExplorer.enableAppPublisher": false,
    "taskExplorer.enableBatch": false,
    "taskExplorer.enableGrunt": false,
    "taskExplorer.enableGulp": false,
    "taskExplorer.enableGradle": false,
    "taskExplorer.enableNpm": false,
    "taskExplorer.enableNsis": false,
    "taskExplorer.enablePowershell": false,
    "taskExplorer.enablePerl": false,
    "taskExplorer.enablePython": false,
    "taskExplorer.enableBash": false,
    "taskExplorer.enableRuby": false,
    "taskExplorer.enableTsc": false,
    "taskExplorer.pathToMake": "make",
    "taskExplorer.groupDashed": true,
    "taskExplorer.numLastTasks": 1,
    "taskExplorer.exclude": ["vendor/**", "bin/.phpunit/**"]
}

At first, it works as expected and shows the make targets of my Makefile (notice that in this very moment, the exclusion is still irrelevant because such directories do not even exist):

image

Then, I download the dependencies so vendor/ is populated; and run the phpunit tests to bin/.phpunit is populated, and TaskExplorer shows too much tasks:

image

Ugly. I restart VSCode and the wrong makefiles disappear again :-)

image

Cool again. I can live with it, but I wanted to report it.

@spmeesseman
Copy link
Owner

thanks for the report, i will look into as soon as i have a chance

@spmeesseman spmeesseman added bug Something isn't working todo labels Jun 15, 2020
@spmeesseman spmeesseman added completed and removed todo labels Feb 7, 2021
spmeesseman added a commit that referenced this issue Feb 8, 2021
# [1.30.0](v1.29.0...v1.30.0) (2021-02-08)

### Bug Fixes

* adding/modifying/deleting task files in excluded paths causes tree to refresh. [fixes [#92](#92)] ([1a980ce](1a980ce))
* after disabling a task type in settings, modification or additions to files of that type still refresh the tree view. ([0fb783d](0fb783d))
* not recognizing gulpfile.mjs. [fixes [#120](#120)] ([8bc2cbb](8bc2cbb))
* opening ant task does not find correct position if it is the default task ([62fe08c](62fe08c))
* opening gulp tasks does not find correct position if not defined as gulp.task. ([fa351e1](fa351e1))
* when opening a vscode/workspace task, task position is not located properly if no label property exists. ([4870016](4870016))

### Build System

* resolve 10 dependency security vulnerabilities ([10e0283](10e0283))
* update all dependecies, vsce 1.85 ([e019b30](e019b30))

### Code Refactoring

* allow gradle tasks to use 'run with arguments' command. [closes [#88](#88)] ([8784e00](8784e00))
* if 'detail' is defined on a task definition, then display it in it's representative tree item tooltip ([e0f45f6](e0f45f6))

### Documentation

* **redame:** add feature images for 1.29 and 1.30 ([e773624](e773624))
* **readme:** add yarn image ([54dec21](54dec21))

### Features

* add 'run with arguments' and 'run with no terminal' commands to script file tasks ([c75d9aa](c75d9aa))
* Add inline open task button ([1bad6d9](1bad6d9))
* add new setting for default item click action. [closes [#97](#97)] ([c4e2ad0](c4e2ad0))
spmeesseman added a commit that referenced this issue Feb 8, 2021
# [1.30.0](v1.29.0...v1.30.0) (2021-02-08)

### Bug Fixes

* adding/modifying/deleting task files in excluded paths causes tree to refresh. [fixes [#92](#92)] ([1a980ce](1a980ce))
* after disabling a task type in settings, modification or additions to files of that type still refresh the tree view. ([0fb783d](0fb783d))
* editing a package.json or tasks.json file no longer refresh the treeview with changes ([de6ffe2](de6ffe2))
* not recognizing gulpfile.mjs. [fixes [#120](#120)] ([8bc2cbb](8bc2cbb))
* opening ant task does not find correct position if it is the default task ([62fe08c](62fe08c))
* opening gulp tasks does not find correct position if not defined as gulp.task. ([fa351e1](fa351e1))
* when opening a vscode/workspace task, task position is not located properly if no label property exists. ([4870016](4870016))

### Build System

* **semantic-release:** fix vsce upgrade breaks vs marketplace release ([9d31d55](9d31d55))
* resolve 10 dependency security vulnerabilities ([10e0283](10e0283))
* update all dependecies, vsce 1.85 ([e019b30](e019b30))

### Code Refactoring

* allow gradle tasks to use 'run with arguments' command. [closes [#88](#88)] ([8784e00](8784e00))
* if 'detail' is defined on a task definition, then display it in it's representative tree item tooltip ([e0f45f6](e0f45f6))

### Documentation

* **redame:** add feature images for 1.29 and 1.30 ([e773624](e773624))
* **readme:** add yarn image ([54dec21](54dec21))

### Features

* add 'run with arguments' and 'run with no terminal' commands to script file tasks ([c75d9aa](c75d9aa))
* Add inline open task button ([1bad6d9](1bad6d9))
* add new setting for default item click action. [closes [#97](#97)] ([c4e2ad0](c4e2ad0))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working completed
Projects
None yet
Development

No branches or pull requests

2 participants