Fix CMake debug optimization flags on MinGW #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Santiago Bernardino <santibberna@gmail.com>
spnda
approved these changes
Nov 24, 2024
spnda
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been working on a MinGW CMake project and noticed that my debug optimization level was
-Ogas opposed to-O0without changing it myself. I found out that fastgltf declares-Ogas a PUBLIC compilation flag on debug builds in MinGW.This pull request simply replaces the PUBLIC specifier to PRIVATE, stopping this flag from leaking to users of the library. With this change the library still correctly compiles and loads models correctly, but it is worth testing if this doesn't break any specific use case.