Ensure reset of deferred validation #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 29, 2022
dpep
force-pushed
the
ensure-validation_deferred
branch
from
4d66c27
to
a1da0c1
Compare
dpep
commented
Oct 30, 2022
Can you put those in a separate PR? |
dpep
force-pushed
the
ensure-validation_deferred
branch
from
a1da0c1
to
b65c1c3
Compare
Merged
dentarg
reviewed
Dec 15, 2022
dentarg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was digging through this code and noticed a few things that could be tightened up (it's generally an awesome library though, so thanks!). Forgive me if this is unwelcomed feedback.
There is an edge case where the block in defer_validation could raises an exception and validation_deferred isn't reset properly. Perhaps contrived, but I thought it worth addressing. The rest are more cosmetic suggestions to make this code simpler / more Rubyish