Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various: fix miscellaneous typos #530

Merged
merged 1 commit into from
Jan 13, 2024
Merged

various: fix miscellaneous typos #530

merged 1 commit into from
Jan 13, 2024

Conversation

p-linnane
Copy link
Contributor

This PR aims to fix various minor typos across the codebase. I noticed some of these when doing the same review on our Homebrew/brew repo, since we use addressable.

Signed-off-by: Patrick Linnane <patrick@linnane.io>
@dentarg dentarg merged commit b136f7d into sporkmonger:main Jan 13, 2024
34 checks passed
@p-linnane p-linnane deleted the fix-various-typos branch January 13, 2024 16:07
@p-linnane
Copy link
Contributor Author

@dentarg any chance you'd be able to cut a patch release? We aren't able to see this downstream without one. Thanks!

@dentarg
Copy link
Collaborator

dentarg commented Feb 16, 2024

Patch release for doc fixes? Hehe, that's a first for me

What project is downstream? Curious

@p-linnane
Copy link
Contributor Author

I'm a maintainer for Homebrew (https://github.com/Homebrew/brew). I'm working on remedying typos in our codebase, and since we use addressable, the typos I fixed in this PR are showing up in my results.

@p-linnane
Copy link
Contributor Author

It's not a big deal if you don't want to cut a patch release for this. I can wait til the next actual release, I just figured I'd ask 😄.

@dentarg
Copy link
Collaborator

dentarg commented Feb 16, 2024

No release planned right now, no actual code changes has happen since last release :)

I do want to automate the release process a bit so cutting one just for the sake of it may happen. No promises though.

@p-linnane
Copy link
Contributor Author

Sounds good. Thank you! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants