This repository has been archived by the owner on Mar 21, 2022. It is now read-only.
integrate revamped authentication support from docker-client #339
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This largely mirrors changes done in dockerfile-maven to integrate the
new authentication support from docker-client.
The plugin now loads credentials from three places, in order:
Any credentials stored in ~/.dockercfg or ~/.docker/config.json
(Optional) Google Cloud credentials, either loaded through the
DOCKER_GOOGLE_CREDENTIALS environment variable or Google's automatic
resolution process for credentials
Last precedence is given to any explicitly configured credentials in
the plugin's configuration.
The
useConfigFile
parameter is no longer used as authentication infofrom the docker configuration file is always activated.
One of the big motivations of the revamped authentication support in
docker-client was to address long-standing issues in this plugin in
regards to being able to authenticate against multiple registries, as
the previous implementation assumed that the same credentials would be
used for any possible registry.
Closes #326, #284, #252, and probably more.
For more reference see:
mvn deploy
. Has failing in… dockerfile-maven#13