Fix empty sample buffers returned when seeking FLAC files. #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psobot
force-pushed
the
psobot/flac-silence
branch
from
705091e to
cd4c60f
Compare
psobot
force-pushed
the
psobot/flac-silence
branch
from
cd4c60f to
95fd164
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #170.
See juce-framework/JUCE#1157 for the root cause. This PR vendors the
juce::FlacAudioFormatclasses to manually patch out two lines of code that were causing the issue.A nearby bug was also fixed: if reading a
PythonInputStreamto its end, all subsequent calls toPythonInputStream::isExhaustedwould continue to returntrue, even if that stream had been seeked back to an earlier point.