Add support for external instrument plugins. #225
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18 and #220.
This PR allows Pedalboard to load and run third-party (VST/AU) instrument plugins, in addition to its existing support for effect plugins.
To accommodate this, this PR adds:
__call__
method onExternalPlugin
that takes MIDI messages as input, rather than audio.is_instrument
andis_effect
properties onPlugin
that allow users to determine if any instance ofPlugin
is an instrument plugin (i.e.: accepts only MIDI as input, returns audio) or an effect plugin (accepts audio and returns audio).TODO:
AudioStream
objectsExample usage: