Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use base64 encoding #3003

Merged
merged 1 commit into from
Jun 1, 2020
Merged

Conversation

regadas
Copy link
Contributor

@regadas regadas commented May 22, 2020

Fixes #3000

@codecov
Copy link

codecov bot commented May 22, 2020

Codecov Report

Merging #3003 into master will decrease coverage by 2.65%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3003      +/-   ##
==========================================
- Coverage   72.72%   70.07%   -2.66%     
==========================================
  Files         225      225              
  Lines        7498     7498              
  Branches      326      301      -25     
==========================================
- Hits         5453     5254     -199     
- Misses       2045     2244     +199     
Impacted Files Coverage Δ
...a/com/spotify/scio/extra/bigquery/ToTableRow.scala 85.71% <ø> (ø)
...scala/com/spotify/scio/bigquery/client/Cache.scala 0.00% <0.00%> (-74.08%) ⬇️
.../spotify/scio/bigquery/client/BigQueryConfig.scala 0.00% <0.00%> (-70.59%) ⬇️
.../spotify/scio/bigquery/BigQueryPartitionUtil.scala 0.00% <0.00%> (-52.50%) ⬇️
...scala/com/spotify/scio/bigquery/BigQueryUtil.scala 50.00% <0.00%> (-50.00%) ⬇️
...otify/scio/bigquery/syntax/ScioContextSyntax.scala 19.35% <0.00%> (-41.94%) ⬇️
...la/com/spotify/scio/bigquery/client/QueryOps.scala 0.73% <0.00%> (-39.71%) ⬇️
.../scala/com/spotify/scio/bigquery/StorageUtil.scala 0.00% <0.00%> (-36.85%) ⬇️
...com/spotify/scio/bigquery/types/BigQueryType.scala 58.33% <0.00%> (-29.17%) ⬇️
...la/com/spotify/scio/bigquery/client/TableOps.scala 0.00% <0.00%> (-25.00%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 766c76d...d630549. Read the comment docs.

@nevillelyh nevillelyh merged commit f1563f2 into spotify:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong base64 encoding used in BigQuery scio-extra
2 participants