Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -release 8 scalac option #3006

Merged
merged 2 commits into from
Jun 1, 2020
Merged

Conversation

regadas
Copy link
Contributor

@regadas regadas commented May 22, 2020

Fixes #3000

This flag will force scala to target 8 to avoid the mentioned issue when compiling/publishing with jdk11. It doesn't play well in some other situations (read thread) and in our case I had to disabled it in scio-repl (ClassLoader issues) and while doing doc generation. In both these cases it's not really important that this flag is enabled.

@codecov
Copy link

codecov bot commented May 22, 2020

Codecov Report

Merging #3006 into master will decrease coverage by 2.62%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3006      +/-   ##
==========================================
- Coverage   72.72%   70.09%   -2.63%     
==========================================
  Files         225      225              
  Lines        7498     7498              
  Branches      326      319       -7     
==========================================
- Hits         5453     5256     -197     
- Misses       2045     2242     +197     
Impacted Files Coverage Δ
...scala/com/spotify/scio/bigquery/client/Cache.scala 0.00% <0.00%> (-74.08%) ⬇️
.../spotify/scio/bigquery/client/BigQueryConfig.scala 0.00% <0.00%> (-70.59%) ⬇️
.../spotify/scio/bigquery/BigQueryPartitionUtil.scala 0.00% <0.00%> (-52.50%) ⬇️
...scala/com/spotify/scio/bigquery/BigQueryUtil.scala 50.00% <0.00%> (-50.00%) ⬇️
...otify/scio/bigquery/syntax/ScioContextSyntax.scala 19.35% <0.00%> (-41.94%) ⬇️
...la/com/spotify/scio/bigquery/client/QueryOps.scala 0.73% <0.00%> (-39.71%) ⬇️
.../scala/com/spotify/scio/bigquery/StorageUtil.scala 0.00% <0.00%> (-36.85%) ⬇️
...com/spotify/scio/bigquery/types/BigQueryType.scala 58.33% <0.00%> (-29.17%) ⬇️
...la/com/spotify/scio/bigquery/client/TableOps.scala 0.00% <0.00%> (-25.00%) ⬇️
...com/spotify/scio/bigquery/types/TypeProvider.scala 52.11% <0.00%> (-22.54%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 766c76d...4b66a07. Read the comment docs.

@regadas regadas merged commit c66075f into spotify:master Jun 1, 2020
@regadas regadas deleted the 3001_bytebuffer_jdk11 branch June 1, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong base64 encoding used in BigQuery scio-extra
2 participants