Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the deprecated SemanticRuleSuite trait in Scalafix #3796

Merged
merged 1 commit into from
May 5, 2021

Conversation

mlachkar
Copy link
Contributor

@mlachkar mlachkar commented May 5, 2021

No description provided.

@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #3796 (7fcee0d) into main (fa73ddc) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

❗ Current head 7fcee0d differs from pull request most recent head 77dc58e. Consider uploading reports for the commit 77dc58e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3796      +/-   ##
==========================================
- Coverage   69.00%   68.99%   -0.01%     
==========================================
  Files         273      273              
  Lines        7795     7796       +1     
  Branches      371      369       -2     
==========================================
  Hits         5379     5379              
- Misses       2416     2417       +1     
Impacted Files Coverage Δ
...rc/main/scala/com/spotify/scio/util/ScioUtil.scala 64.00% <50.00%> (-1.22%) ⬇️
...spotify/scio/values/PairSCollectionFunctions.scala 98.08% <100.00%> (+1.25%) ⬆️
...in/scala/com/spotify/scio/values/SCollection.scala 94.04% <100.00%> (ø)
...y/scio/values/PairSkewedSCollectionFunctions.scala 93.24% <0.00%> (-2.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa73ddc...77dc58e. Read the comment docs.

Copy link
Contributor

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mlachkar

@regadas regadas merged commit 37b4a83 into spotify:main May 5, 2021
@mlachkar mlachkar deleted the scalafix branch May 6, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants