Consistent implementation for reduce operation #5498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RustedBones
commented
Sep 19, 2024
| @@ -793,7 +793,7 @@ sealed trait SCollection[T] extends PCollectionWrapper[T] { | |||
| val e = ev // defeat closure | |||
| in.map(e.toDouble) | |||
| .asInstanceOf[SCollection[JDouble]] | |||
| .pApply(Mean.globally()) | |||
| .pApply(Mean.globally().withoutDefaults()) | |||
There was a problem hiding this comment.
without that, mean returns NaN for empty collection instead
RustedBones
force-pushed
the
consistent-empty-reduce
branch
from
84bfe56
to
6161584
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5498 +/- ##
==========================================
- Coverage 61.40% 61.40% -0.01%
==========================================
Files 312 312
Lines 11101 11106 +5
Branches 738 771 +33
==========================================
+ Hits 6817 6820 +3
- Misses 4284 4286 +2 ☔ View full report in Codecov by Sentry. |
RustedBones
force-pushed
the
consistent-empty-reduce
branch
from
f0adc4b
to
43741c2
Compare
RustedBones
force-pushed
the
consistent-empty-reduce
branch
from
43741c2
to
6adcab8
Compare
kellen
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.