Don't report empty histograms to FastForward #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spkrka
force-pushed
the
krka/empty-histograms
branch
2 times, most recently
from
a90084d
to
411f5eb
Compare
*Rationale* If histograms don't have any reported values, or have not been used in a long time, the snapshot is empty and the histogram metrics will not have a reasonable default value. All stats (min, max, median, etc) would incorrectly be reported as zero *Performance impact* The performance impact should be minimal, since it only adds one additional if-check when reporting histograms. Snapshot.size() is a fast method, simply returning the length of its internal array. For cases where snapshots are empty - i.e. unused histograms we should see a performance improvement since we can skip emitting the data points to FastForward as well as skipping the creation of the metric ids.
spkrka
force-pushed
the
krka/empty-histograms
branch
from
411f5eb
to
d7dea0d
Compare
roadr
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
If histograms don't have any reported values, or have not been used
in a long time, the snapshot is empty and the histogram metrics
will not have a reasonable default value. All stats (min, max, median, etc) would
incorrectly be reported as zero
Performance impact
The performance impact should be minimal, since it only adds one additional
if-check when reporting histograms. Snapshot.size() is a fast method, simply
returning the length of its internal array.
For cases where snapshots are empty - i.e. unused histograms we should see
a performance improvement since we can skip emitting the data points to FastForward
as well as skipping the creation of the metric ids.