Skip to content

Commit

Permalink
Add envFrom to operator deployment (kubeflow#1785)
Browse files Browse the repository at this point in the history
* Add envFrom to operator deployment

Useful to when env vars are used for auth when downloading `spark.archives` from S3.

* Fix over-indenting
  • Loading branch information
matschaffer-roblox authored and sigmarkarl committed Aug 7, 2024
1 parent 29b30da commit 094640a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
2 changes: 2 additions & 0 deletions charts/spark-operator-chart/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ spec:
- name: {{ .Chart.Name }}
image: {{ .Values.image.repository }}:{{ default .Chart.AppVersion .Values.image.tag }}
imagePullPolicy: {{ .Values.image.pullPolicy }}
envFrom:
{{- toYaml .Values.envFrom | nindent 10 }}
securityContext:
{{- toYaml .Values.securityContext | nindent 10 }}
{{- if .Values.metrics.enable }}
Expand Down
3 changes: 3 additions & 0 deletions charts/spark-operator-chart/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ ingressUrlFormat: ""
# -- Set higher levels for more verbose logging
logLevel: 2

# -- Pod environment variable sources
envFrom: []

# podSecurityContext -- Pod security context
podSecurityContext: {}

Expand Down

0 comments on commit 094640a

Please sign in to comment.