Creates script to preserve menu's scroll position on click. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for subtle-medovik-58f1c6 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@SaptakS I switched this to draft--there's some jitter and I'm not confident it works. I might just need to clear my cache--will dbl check |
SaptakS
reviewed
Sep 20, 2023
| // Attaches an event listener to the window's beforeunload event to store the scroll position | ||
| window.addEventListener('beforeunload', storeScrollPosition); | ||
| // Calls the restoreScrollPosition function when the page loads | ||
| window.addEventListener('load', restoreScrollPosition); |
There was a problem hiding this comment.
Try maybe DOMContentLoaded. Also, you can put this JS in head instead of end of body, to make this JS run at the very beginning. These 2 might help reduce the jump timing. There will still always be a microsecond of jump between DOM being loaded and JS being executed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve issue #64
@SaptakS @Erioldoesdesign I prioritized creating a script for this because it's actually a bit challenging to browse the site otherwise.