Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove page from whitelisted parameters #10811

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

KacperMekarski
Copy link
Contributor

@KacperMekarski KacperMekarski commented Mar 1, 2021

SEMrush seo report shows that we should remove page param from whitelist because it treats same URL as different sites:

SEO report example:
Screenshot 2021-03-01 at 13 25 47

@KacperMekarski
Copy link
Contributor Author

@MatthewKennedy yes, we have canonical meta tags included by CanonicalRails, but page param is whitelisted here so finally in case of index action it doesn't work as expected.
For example, when you enter https://spree-designs-staging.herokuapp.com/products?page=1, we have canonical tag as below:

Screenshot 2021-03-01 at 13 36 57

When we remove page param from whitelist, we will have valid reference without query string.
Please have a look at this comment:

# Parameter spamming can cause index dilution by creating seemingly different URLs with identical or near-identical content.

@MatthewKennedy
Copy link
Contributor

Good catch!

@damianlegawiec damianlegawiec merged commit ec5e4f5 into master Mar 1, 2021
@delete-merged-branch delete-merged-branch bot deleted the canonical_tag_optimization branch March 1, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants