Bump Typescript version to 4.9.3 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshalot
reviewed
Dec 1, 2022
fpdrozd
force-pushed
the
feat/update-typescript
branch
from
ef20cec to
2861457
Compare
kshalot
approved these changes
Dec 2, 2022
|
Also one comment for the future - I'd opt for creating separate PRs for non-major (not breaking) dependency bumps and code changes resulting from them |
|
@kshalot you mean my change with the if statement? - Yeah, I think it's a good practice to separate them. |
Yes, that's what I meant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.