feat: add recommendations depending on the platform #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
letelete
reviewed
Jan 23, 2023
rafalcymerys
force-pushed
the
feat/spree_option_recommendation
branch
from
d8da4bc to
83180e2
Compare
|
@letelete good points, I updated the PR. Please take a look one more time when you have a moment :) |
letelete
approved these changes
Jan 24, 2023
| @@ -0,0 +1,65 @@ | |||
| import { buildSpreeChoices } from '../../../src/domains/spree'; | |||
There was a problem hiding this comment.
I was just thinking, we could replace relative paths with absolute ones (for all project files, in a dedicated PR). Relative paths are quite messy and difficult to read, which leads to mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a support for recommendedForPlatforms field in Spree Template.s
We've noticed that a lot of people try to use the dockerized version on Mac, which has some severe performance issues caused by the slow filesystem sync between mac and docker. For an application of this size, this causes it to work really slow.
With this PR, it's possible to tag a template as recommended for a certain platform - in such case, the CLI will prioritize it when running on given OS and will display "Recommended" next to the name of the template.