Fix basic auth with encoded characters (#3815) #4260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlgaMaciaszek
requested changes
Mar 25, 2024
There was a problem hiding this comment.
Hello @ZIRAKrezovic, thanks for creating the PR. Please add a test. Please add your full name and surname with @author tag to the javadoc of any classes you've modified.
|
Hi @OlgaMaciaszek, I have added a test. Although I'm not sure if it's the right approach, or if it can be done with unit tests without a server, it tests what this fix is supposed to fix. |
|
I have found out how Spring Webflux developers do the tests and updated my test accordingly. |
OlgaMaciaszek
requested changes
Apr 2, 2024
There was a problem hiding this comment.
Thanks @ZIRAKrezovic. Looks good. Have just added comments about some cosmetic issues. Please fix.
.../java/org/springframework/cloud/netflix/eureka/http/WebClientTransportClientFactoryTest.java
Show resolved
Hide resolved
.../java/org/springframework/cloud/netflix/eureka/http/WebClientTransportClientFactoryTest.java
Show resolved
Hide resolved
.../java/org/springframework/cloud/netflix/eureka/http/WebClientTransportClientFactoryTest.java
Outdated
Show resolved
Hide resolved
.../java/org/springframework/cloud/netflix/eureka/http/WebClientTransportClientFactoryTest.java
Outdated
Show resolved
Hide resolved
OlgaMaciaszek
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3815