Add support for configuring RestTemplate via RestTemplateBuilder (#4255) #4262
Conversation
ZIRAKrezovic
force-pushed
the
gh-4255
branch
from
d14c67f
to
9161c83
Compare
There was a problem hiding this comment.
Thanks, @ZIRAKrezovic. This looks good. Please just address the comment about the javadoc and licensce changes in the classes you've edited.
| @@ -69,11 +70,11 @@ public TlsProperties tlsProperties() { | |||
| @ConditionalOnProperty(prefix = "eureka.client", name = "webclient.enabled", matchIfMissing = true, | |||
| havingValue = "false") | |||
| public RestTemplateDiscoveryClientOptionalArgs restTemplateDiscoveryClientOptionalArgs(TlsProperties tlsProperties, | |||
| EurekaClientHttpRequestFactorySupplier eurekaClientHttpRequestFactorySupplier) | |||
| throws GeneralSecurityException, IOException { | |||
| EurekaClientHttpRequestFactorySupplier eurekaClientHttpRequestFactorySupplier, | |||
There was a problem hiding this comment.
Please add your full name and surname with @author tag to the javadoc of all the files you've modified. Please update the year in the license comments of the files you've modified.
There was a problem hiding this comment.
@ZIRAKrezovic Actually, I'm just going to do it for you, since I'd like to make sure we include this in the upcoming release.
|
Thanks! |
|
@ZIRAKrezovic Did it, but the changes cause test failures (for some reason, the build was apparently not triggered on your PR). Will revert them - please resubmit your PR with fixed tests. |
|
@ZIRAKrezovic - see details: https://github.com/spring-cloud/spring-cloud-netflix/actions/runs/8440522374/job/23117589376. Some tests will need updating to the new API. |
|
Hi @OlgaMaciaszek. I did a rebase, applied your patch that fixes the copyright year and author, and fixed the compilation of the failed test. |
|
Thanks @ZIRAKrezovic . |
Fixes: #4255