Improve EurekaConfigServerInstanceProvider #4267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlgaMaciaszek
requested changes
Mar 26, 2024
There was a problem hiding this comment.
Hello @Puppy4C, thanks for submitting the PR. Please fix the tests and make sure the build passes. Also, update the year in the license comment of any files you change to 2013-2024.
Puppy4C
force-pushed
the
Puppy4C-patch-1
branch
from
a4e8f6c
to
aa3f90a
Compare
Puppy4C
changed the title
Puppy4C
force-pushed
the
Puppy4C-patch-1
branch
from
aa3f90a
to
0bb616e
Compare
|
Hi @OlgaMaciaszek ，I have fixed the tests and updated the license comment，please review. |
OlgaMaciaszek
requested changes
Apr 2, 2024
...java/org/springframework/cloud/netflix/eureka/config/EurekaConfigServerInstanceProvider.java
Outdated
Show resolved
Hide resolved
...ringframework/cloud/netflix/eureka/config/EurekaConfigServerBootstrapConfigurationTests.java
Show resolved
Hide resolved
OlgaMaciaszek
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameter
regionsin theclient.getApplications()method represents remoteRegions, which indicates that the registry should not only retrieve and return a list of its own nodes, but also return a list of remoteRegions.But
config.getRegion()represents the local region, and if this parameter is included, the registry will continue to print:No remote registry available for the remote region xxxWe should refer to
com.netflix.discovery.DiscoveryClient#getAndStoreFullRegistryand useconfig.fetchRegistryForRemoteRegions()instead of it