GH-2847: Multiple outputs routing-key-expression #2864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When there are multiple output bindings present and one of them defines a routing-key-expression, there is a bug that bypasses the code that skips the output conversion. This results in the framework attempts a pre-mature type conversion causing in later downstream errors. This happens because MessageConverterConfigurer tries to find a corresponding function for the entire function definition rather than using the individual function under consideraion. Fixing this issue by properly keeping track of the function name keyed off of the channel name, since channel name is what MessageConverterConfigurer uses to retrieve info about the function name. Resolves spring-cloud#2847
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2847