Skip to content

Commit

Permalink
Fixed the bug where spring.cloud.task.transaction-manager was not wor…
Browse files Browse the repository at this point in the history
…king

Added additional for the default case
  • Loading branch information
lianej authored and cppwfs committed Nov 17, 2023
1 parent a2145b2 commit 8f1b318
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
class NoTransactionManagerProperty extends NoneNestedConditions {

NoTransactionManagerProperty() {
super(ConfigurationPhase.PARSE_CONFIGURATION);
super(ConfigurationPhase.REGISTER_BEAN);
}

@ConditionalOnProperty(prefix = "spring.cloud.task", name = "transaction-manager")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@

import org.springframework.aop.framework.AopProxyUtils;
import org.springframework.aop.scope.ScopedProxyUtils;
import org.springframework.batch.support.transaction.ResourcelessTransactionManager;
import org.springframework.beans.factory.BeanCreationException;
import org.springframework.beans.factory.NoSuchBeanDefinitionException;
import org.springframework.beans.factory.annotation.Autowired;
Expand All @@ -47,6 +48,7 @@
import org.springframework.context.ConfigurableApplicationContext;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.transaction.PlatformTransactionManager;

import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
Expand Down Expand Up @@ -173,6 +175,32 @@ public void testMultipleDataSources() {

}

@Test
void testSpecifyTransactionManager() {
ApplicationContextRunner applicationContextRunner = new ApplicationContextRunner()
.withConfiguration(AutoConfigurations.of(PropertyPlaceholderAutoConfiguration.class,
SimpleTaskAutoConfiguration.class, SingleTaskConfiguration.class))
.withBean("transactionManager", ResourcelessTransactionManager.class)
.withPropertyValues("spring.cloud.task.transaction-manager=transactionManager");
applicationContextRunner.run((context) -> {
assertThat(context.getBeanNamesForType(PlatformTransactionManager.class)).hasSize(1)
.contains("transactionManager")
.doesNotContain("springCloudTaskTransactionManager");
});
}

@Test
void testDefaultTransactionManager() {
ApplicationContextRunner applicationContextRunner = new ApplicationContextRunner()
.withConfiguration(AutoConfigurations.of(PropertyPlaceholderAutoConfiguration.class,
SimpleTaskAutoConfiguration.class, SingleTaskConfiguration.class));
applicationContextRunner.run((context) -> {
assertThat(context.getBeanNamesForType(PlatformTransactionManager.class)).hasSize(1)
.contains("springCloudTaskTransactionManager")
.doesNotContain("transactionManager");
});
}

public void verifyExceptionThrownDefaultExecutable(Class classToCheck,
ApplicationContextRunner applicationContextRunner) {
Executable executable = () -> {
Expand Down

0 comments on commit 8f1b318

Please sign in to comment.