Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to configure client TLS enabled protocol versions and cipher suites via Spring properties #581

Closed
mryangza opened this issue Mar 16, 2021 · 2 comments

Comments

@mryangza
Copy link

In spring-projects/spring-vault#635 support was added for configuring the enabled client TLS protocols and cipher suites to be configured via Spring application properties. It would be great if we could also configure these via Spring application properties for the Spring Cloud Vault client.

The org.springframework.vault.config.EnvironmentVaultConfiguration.sslConfiguration() was updated to set protocol and cipher suites on the org.springframework.vault.support.SslConfiguration instance returned. The org.springframework.cloud.config.server.environment.vault.SpringVaultClientConfiguration.sslConfiguration() method could be updated to do the same.

@mp911de mp911de added this to the 3.0.2 milestone Mar 16, 2021
@mp911de
Copy link
Member

mp911de commented Mar 16, 2021

That's in place now.

@mryangza
Copy link
Author

Awesome, thank you! I realized now that org.springframework.cloud.config.server.environment.vault.SpringVaultClientConfiguration is actually part of spring-cloud-config. I'll submit a feature request there too.

spencergibb pushed a commit that referenced this issue Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants