Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add java8 time api capabilities in DTOs & Model #58

Merged
merged 5 commits into from
Nov 24, 2021

Conversation

alexandre-touret
Copy link
Contributor

Fix #57

How does it work ?

  • Add java8 time api generation for DTOs using OPENAPIGenerator
  • Change model POJOs date to LocalDate

How was it tested?

This PR was validated running the unit and integration tests

@alexandre-touret
Copy link
Contributor Author

Hi @arey
I fixed the issues you pointed out.

@arey
Copy link
Member

arey commented Nov 12, 2021

Thank you @alexandre-touret Could you check why code coverage has decreased?

@alexandre-touret
Copy link
Contributor Author

alexandre-touret commented Nov 16, 2021

Hi @arey
I just checked and reproduced this issue on my laptop.

It fails now because in the github action definition, it's now

      - name: Build with Maven
        run: mvn -B install --file pom.xml

instead of

      - name: Build with Maven
        run: mvn -B package --file pom.xml

The install step checks the jacoco report and fails the build if the coverage rate is not high enough.

@arey
Copy link
Member

arey commented Nov 21, 2021

So you have to add some lines of test or decrease the limit of the code coverage.

@arey arey merged commit 96694d5 into spring-petclinic:master Nov 24, 2021
@alexandre-touret alexandre-touret deleted the feature/java8-time-api branch November 27, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to LocalDate from the Java 8 Date Time API
2 participants