Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAI: Add gpt-o1/o1-mini to chat model enum #1356

Closed
wants to merge 1 commit into from

Conversation

PARK-afk
Copy link
Contributor

Thank you for taking time to contribute this pull request!
You might have already read the [contributor guide][1], but as a reminder, please make sure to:

  • Sign the contributor license agreement
  • Rebase your changes on the latest main branch and squash your commits
  • Add/Update unit tests as needed
  • Run a build and make sure all tests pass prior to submission

@dafriz
Copy link
Contributor

dafriz commented Sep 14, 2024

According to the OpenAI api docs these new model names don't start with gpt. Should be o1-mini etc.
See https://platform.openai.com/docs/models/o1

@markpollack
Copy link
Member

merged in 40eaa99

🙇

@markpollack markpollack added this to the 1.0.0-M3 milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants