Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PromptTemplate added ChatOptions support #516

Closed
wants to merge 17 commits into from

Conversation

zhangqian9158
Copy link
Contributor

PromptTemplate added ChatOptions support

@tzolov tzolov added this to the 1.0.0-M1 milestone Apr 26, 2024
@zhangqian9158
Copy link
Contributor Author

@tzolov tzolov modified the milestones: 1.0.0-M1, 1.0.0-M2 May 28, 2024
@zhangqian9158 zhangqian9158 marked this pull request as draft June 7, 2024 02:14
@zhangqian9158 zhangqian9158 marked this pull request as ready for review June 7, 2024 02:15
@zhangqian9158
Copy link
Contributor Author

If there is no modification, please merge the PR @tzolov @markpollack

@markpollack
Copy link
Member

I was not able to rebase this as there are so many commits. in the future please squash. I have also added test.
thanks for the contribution. merged in dad30f0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants