🩹 Add google search retrieval as builtin tool #669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grogdunn
force-pushed
the
vertex-google-search-retrieval
branch
from
d937c4d
to
70cb780
Compare
|
aligned with main |
markpollack
reviewed
Aug 22, 2024
| List<Tool> tools = this.getFunctionTools(functionsForThisRequest); | ||
| tools.addAll(this.getFunctionTools(functionsForThisRequest)); | ||
| } | ||
| if (((VertexAiGeminiChatOptions) prompt.getOptions()).getGoogleSearchRetrieval()) { |
There was a problem hiding this comment.
There is a NPE here when running the tests. I have fixed it, but it means this code wasn't really verified.
In future, please add a test to verify the behavior.
markpollack
reviewed
Aug 22, 2024
| * Use Google search Grounding feature | ||
| */ | ||
| @JsonIgnore | ||
| private boolean googleSearchRetrieval = false; |
There was a problem hiding this comment.
also needs to be part of the fromOptions method.
|
merged in 793052c I had a bad merge conflict somehow and ended up redoing the changes and adding a test on another branch. Sorry I forgot to add your name in the commit message. next time! ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in Vertex client configuration the possibility to use GoogleSearchRetrieval as tool as grounding feature
https://cloud.google.com/vertex-ai/generative-ai/docs/model-reference/grounding
next up (on other PR) grounding support with "retrieval" tool, more studies needed.