Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could com.example:spring-rabbit-global-errorhandler:2.3.10 drop off redundant dependencies to loose weight? #65

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Celebrate-future
Copy link

@Celebrate-future Celebrate-future commented Aug 5, 2021

@garyrussell Hi, I am a user of project com.example:spring-rabbit-global-errorhandler:2.3.10. I found that its pom file introduced 58 dependencies. However, among them, 7 libraries (12%) have not been used by your project (the redundant dependencies are listed below). Reduce these useless dependencies can help prevent conflicts between library versions. MeanWhile, it can minimize the total added size to projects. It can also help enable advanced scenarios for this project.
This PR helps com.example:spring-rabbit-global-errorhandler:2.3.10 lose weight :) I have tested the revised configuration in my local environment. It is safe to remove the unused libraries.

Best regards

@pivotal-cla
Copy link

@Celebrate-future Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@Celebrate-future Thank you for signing the Contributor License Agreement!

@@ -63,6 +69,110 @@
</plugin>
</plugins>
</build>


<dependencyManagement>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this explicit management over here?
The spring-boot-starter-parent is actual parent for this project and that one already manages all the versions for dependencies we use in this project.
I may find the exclusion for spring-boot-starter-logging as a reasonable, but I can't guess the point of this dependency management.
That really was the whole reason to introduce Spring Boot from day first...

Thank you for understanding!

@Celebrate-future
Copy link
Author

I have updated the pom file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants