Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression with the CSS styles and JS toggle in the reference documentation of 4.3.x #4437

Closed
fmbenhassine opened this issue Aug 29, 2023 · 3 comments

Comments

@fmbenhassine
Copy link
Contributor

There seems to be a regression with the css styles in the reference documentation of 4.3.x: https://docs.spring.io/spring-batch/docs/4.3.9/reference/html/

This is probably related to switching to spring-asciidoctor-backends: af61a39

@Buzzardo Could you please take a look? Thank you upfront.

@Buzzardo
Copy link

Buzzardo commented Sep 1, 2023

I took a look and don't see a problem. What are you seeing that's wrong?

@fmbenhassine
Copy link
Contributor Author

Compared to the 4.3.8 version, the spring styles (the banner at the top of the page, the background colour of code blocks, etc) are not rendered:

https://docs.spring.io/spring-batch/docs/4.3.8/reference/html/

https://docs.spring.io/spring-batch/docs/4.3.9/reference/html/

@Buzzardo
Copy link

Buzzardo commented Sep 5, 2023

I built 4.3.x, and it came out correctly. I noticed that it built 4.3.10. When I tried to build 4.3.9, I got a bunch of repository issues, due to the changes of a few months ago that we made to which Spring repositories are available. I think we should ignore 4.3.9 and accept that it's correct in 4.3.10.

@fmbenhassine fmbenhassine changed the title Regression with the css styles in the reference documentation of 4.3.x Regression with the css styles and toggle in the reference documentation of 4.3.x Nov 21, 2023
fmbenhassine added a commit that referenced this issue Nov 21, 2023
@fmbenhassine fmbenhassine changed the title Regression with the css styles and toggle in the reference documentation of 4.3.x Regression with the CSS styles and JS toggle in the reference documentation of 4.3.x Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants