Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for thymeleaf-spring5 in Spring Boot 2.0 #7885

Closed
danielfernandez opened this issue Jan 5, 2017 · 1 comment
Closed

Support for thymeleaf-spring5 in Spring Boot 2.0 #7885

danielfernandez opened this issue Jan 5, 2017 · 1 comment
Labels
type: enhancement A general enhancement
Milestone
2.0.0.M1

Comments

@danielfernandez
Copy link
Contributor

According to #7450, Spring Boot 2.0 will set its Thymeleaf dependency to the 3.0 branch by default (which is great, thanks!).

We have just published the first version of our new thymeleaf-spring5 integration package for Spring 5, with version 3.0.3.M1. It depends on Spring Framework version 5.0.0.M4 and our idea is to keep releasing milestones / release candidates until Spring 5.0.0.RELEASE is published, in which moment we will turn our package into a stable .RELEASE.

Given Spring Boot 2.0 will be based on Spring 5, it would be great if you could adapt Boot to the new thymeleaf-spring5 package.

Also, thymeleaf-spring5 includes support for the new Spring Web Reactive module (or whatever new name you give it in the coming weeks 😃), so it would be awesome if the starter and the autoconfiguration infrastructure could be updated to autoconfigure a reactive web application based on Thymeleaf. It should be very similar to the process for Spring MVC.

We have a couple of sandbox applications already that can be used as an example, see https://github.com/thymeleaf/thymeleafsandbox-stsm-reactive/blob/20170105/src/main/java/thymeleafsandbox/stsm/StsmReactiveWebConfig.java

And of course, I'll be more-than-happy to help you with the task, just contact me.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 5, 2017
@snicoll snicoll added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 5, 2017
@snicoll snicoll added this to the 2.0.0.M1 milestone Jan 5, 2017
@philwebb philwebb modified the milestones: 2.0.0.M1, 2.0.0 Jan 12, 2017
@philwebb philwebb modified the milestones: 2.0.0, 2.0.0.M1 Jan 12, 2017
@wilkinsona wilkinsona assigned wilkinsona and unassigned wilkinsona Jan 25, 2017
wilkinsona added a commit that referenced this issue Jan 25, 2017
@wilkinsona
Upgrade to Thymeleaf 3 and drop support for Thymleaf 2
9bba73a 
This commit raises the minimum supported version of Thymeleaf to
3.0.x. It also upgrades Spring Social to a version that is compatible
with Thymeleaf 3.

Closes gh-7450
Closes gh-6258
See gh-7885
@wilkinsona
Copy link
Member

9bba73a moved us over to thymeleaf-spring5 and we have #8124 open for the reactive side of things so I think we can close this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.0.0.M1
Development

No branches or pull requests
6 participants
@bclozel @snicoll @philwebb @wilkinsona @danielfernandez @spring-projects-issues