Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move appendix subsections under appendix section #29667

Closed

Conversation

mhalbritter
Copy link
Contributor

This involved a small code change to the generated configuration properties snippets: the section id has to start with 'appendix.', otherwise the section-id asciidoctor extension complains.

See #27003

This involved a small code change to the generated configuration properties snippets: the section id has to start with 'appendix.', otherwise the section-id asciidoctor extension complains.

See spring-projectsgh-27003.
@snicoll snicoll added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 7, 2022
@snicoll snicoll added this to the 2.5.x milestone Feb 7, 2022
@philwebb
Copy link
Member

philwebb commented Feb 7, 2022

I like the appending prefix on the section titles, but we should update anchor-rewrite.properties so that older links work.

the format of that file is pretty self explanatory, but it's also covered here

@philwebb philwebb added the for: merge-with-amendments Needs some changes when we merge label Feb 7, 2022
@mhalbritter
Copy link
Contributor Author

Thanks for the hint, I will update that file.

@mhalbritter
Copy link
Contributor Author

Updated the anchors file, anchors are now backward compatible.

@philwebb philwebb removed the for: merge-with-amendments Needs some changes when we merge label Feb 8, 2022
@wilkinsona wilkinsona self-assigned this Feb 9, 2022
wilkinsona pushed a commit that referenced this pull request Feb 9, 2022
This involved a small code change to the generated configuration
properties snippets. The section id has to start with
'appendix.', otherwise the section-id asciidoctor extension
complains. To ensure that the anchors that are derived from the
section IDs remain backwards compatible, the anchor-rewrite
properties have been updated.

See gh-29667
@wilkinsona wilkinsona closed this in 43dc378 Feb 9, 2022
@wilkinsona wilkinsona modified the milestones: 2.5.x, 2.5.10 Feb 9, 2022
@mhalbritter mhalbritter deleted the bugfix/gh-27003 branch February 9, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants