Fix property value conversion in query mapper for nested values. #4517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
judby
reviewed
Sep 29, 2023
| @@ -455,6 +455,15 @@ public <T> T getPropertyValue(MongoPersistentProperty property) { | |||
| return collection.stream().map(it -> valueConverter.write(it, conversionContext)).collect(Collectors.toList()); | |||
| } | |||
|
|
|||
| if(!documentField.getProperty().isMap() && sourceValue instanceof Document document) { | |||
| return new Document(document.entrySet().stream().collect(Collectors.toMap(entry -> entry.getKey(), entry -> { | |||
There was a problem hiding this comment.
minor suggestion: .collect(Collectors.toMap(Entry::getKey, entry -> {
There was a problem hiding this comment.
We had a second look and using the stream API here bears some risks. Entry order may not be preserved and the usage of Collectors API can cause NPE due to JDK-8148463.
christophstrobl
force-pushed
the
issue/4510
branch
from
02f5819
to
98cea43
Compare
4 tasks
christophstrobl
force-pushed
the
issue/4510
branch
from
98cea43
to
75959f6
Compare
Refine nullability declarations and NPE guards. Reformat code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #4510