Doc improvements #4694
Closed
Doc improvements #4694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rechvs Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@pivotal-cla This is an Obvious Fix |
|
@rechvs This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary. |
mp911de
added
type: documentation
|
Care to squash your commits into a single one for easier merging and reviewing? |
Various typo fixes and wording improvements.
@mp911de Done. |
mp911de
pushed a commit
that referenced
this pull request
May 14, 2024
Various typo fixes and wording improvements. Closes #4694
mp911de
added a commit
that referenced
this pull request
May 14, 2024
Refine wording about Id field naming. See #4694
mp911de
added a commit
that referenced
this pull request
May 14, 2024
Refine wording about Id field naming. See #4694
mp911de
reviewed
May 14, 2024
| | `@Field("x")` `@Id` `String` x | ||
| | `_id` | ||
| | `@Field("x")` `@Id` `String` y | ||
| | `x` |
There was a problem hiding this comment.
This is incorrect, @Id takes precedence. I will update the change during the merge.
natedanner
pushed a commit
to natedanner/spring-projects__spring-data-mongodb
that referenced
this pull request
May 20, 2024
Various typo fixes and wording improvements. Closes spring-projects#4694
natedanner
pushed a commit
to natedanner/spring-projects__spring-data-mongodb
that referenced
this pull request
May 20, 2024
Refine wording about Id field naming. See spring-projects#4694
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kept the changes in separate commits mainly to improve reviewability. I’d be happy to squash them before merge.