Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate support for mariadb-r2dbc #1364

Closed
mshima opened this issue Oct 18, 2022 · 10 comments
Closed

Reinstate support for mariadb-r2dbc #1364

mshima opened this issue Oct 18, 2022 · 10 comments
Assignees
Labels
type: enhancement A general enhancement

Comments

@mshima
Copy link

mshima commented Oct 18, 2022

spring-data-r2dbc used to depend on r2dbc bom:
https://github.com/spring-projects/spring-data-r2dbc/blob/e8ba67be6b35d147b5d10ec02bff81a12da75db2/pom.xml#L69-L75

which manages r2dbc-mariadb:
https://github.com/r2dbc/r2dbc-bom/blob/03ff2d7b854d2f162952c5705f2630faf4c501b4/pom.xml#L79-L83

As of version 3.0.0-RC1, r2dbc-mariadb is not managed:

<!-- R2DBC Drivers -->
<dependency>
<groupId>org.postgresql</groupId>
<artifactId>r2dbc-postgresql</artifactId>
<version>${r2dbc-postgresql.version}</version>
<optional>true</optional>
</dependency>
<dependency>
<groupId>io.r2dbc</groupId>
<artifactId>r2dbc-h2</artifactId>
<version>${r2dbc-h2.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.r2dbc</groupId>
<artifactId>r2dbc-mssql</artifactId>
<version>${r2dbc-mssql.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.oracle.database.r2dbc</groupId>
<artifactId>oracle-r2dbc</artifactId>
<version>${oracle-r2dbc.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.r2dbc</groupId>
<artifactId>r2dbc-spi-test</artifactId>
<version>${r2dbc-spi.version}</version>
<scope>test</scope>
</dependency>

Is this a bug or a design decision?

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 18, 2022
@mp911de mp911de added status: invalid An issue that we don't feel is valid and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 24, 2022
@mp911de
Copy link
Member

mp911de commented Oct 24, 2022

That's correct, as there is no 1.0-compliant version of the MariaDB driver.

@mp911de mp911de closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2022
@mraible
Copy link

mraible commented Nov 17, 2022

@mp911de Do you know if there's an issue to track for the 1.0-compliant version? Also, what library are you referring to as 1.0?

@mp911de
Copy link
Member

mp911de commented Nov 17, 2022

1.0 refers to the R2DBC specification version in this context, apologies for ambiguity. MariaDB is stuck on version 0.9 of the R2DBC spec. Upgrading to R2DBC 1.0 doesn't require much of a change, however, the changes are binary incompatible in comparison to 0.9.x.

@mshima
Copy link
Author

mshima commented Nov 17, 2022

@mraible
Copy link

mraible commented Nov 17, 2022

Thanks for the details y'all!

@mshima
Copy link
Author

mshima commented Mar 16, 2023

mariadb-r2dbc should be r2dbc 1.0 compliant now.
@mp911de is there any plan to add mariadb-r2dbc again?

@mp911de mp911de changed the title spring-data-r2dbc doesn't manages r2dbc-mariadb anymore Reinstate support for mariadb-r2dbc Mar 16, 2023
@mp911de mp911de added type: enhancement A general enhancement and removed status: invalid An issue that we don't feel is valid labels Mar 16, 2023
@mp911de mp911de self-assigned this Mar 16, 2023
@mp911de mp911de reopened this Mar 16, 2023
@mp911de
Copy link
Member

mp911de commented Mar 16, 2023

We can do so once the artifact is available from Maven Central.

@mshima
Copy link
Author

mshima commented Mar 16, 2023

@mp911de
Copy link
Member

mp911de commented Mar 16, 2023

For Spring Boot, please file a ticket at https://github.com/spring-projects/spring-boot/issues.

Meanwhile, we're going to reinstate our test support.

mp911de added a commit that referenced this issue Mar 16, 2023
@mp911de mp911de added this to the 3.0.4 (2022.0.4) milestone Mar 16, 2023
@mshima
Copy link
Author

mshima commented Mar 16, 2023

Thanks @mp911de.
For knowledge, mariadb-r2dbc 1.1.4 was released a couple of hours ago, but not available at maven central yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants