Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore null Locale in MockHttpServletResponse #26493

Closed
sbrannen opened this issue Feb 2, 2021 · 0 comments
Closed

Ignore null Locale in MockHttpServletResponse #26493

sbrannen opened this issue Feb 2, 2021 · 0 comments
Assignees
@sbrannen
Labels
in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
5.3.4

Comments

@sbrannen
Copy link
Member

sbrannen commented Feb 2, 2021 •
edited
Loading

This is a follow-up to #26488.

Although the Javadoc for javax.servlet.ServletResponse.setLocale(Locale) does not state how a null value for the supplied Locale should be handled, both Tomcat and Jetty simply ignore a null value.

We will therefore do the same in MockHttpServletResponse.
@sbrannen sbrannen added in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Feb 2, 2021
@sbrannen sbrannen added this to the 5.3.4 milestone Feb 2, 2021
@sbrannen sbrannen self-assigned this Feb 2, 2021
@sync-by-unito sync-by-unito bot mentioned this issue Feb 17, 2021
Merged
This was referenced Mar 7, 2021
Open
Closed
Closed
Open
Open
Closed
Open
Open
Merged
Open
Open
Open
Closed
Merged
Merged
This was referenced Mar 14, 2021
Closed
Open
Open
Merged
Open
Open
Merged
This was referenced Mar 15, 2021
Open
Open
Merged
Open
Open
Open
Open
Open
sbrannen added a commit that referenced this issue Jul 29, 2021
@sbrannen
Add @nullable to setLocale in MockHttpServletResponse
5b3f11c 
See gh-26493
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
@sbrannen @lxbzmy
Add @nullable to setLocale in MockHttpServletResponse
633d4fd 
See spring-projectsgh-26493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
5.3.4
Development

No branches or pull requests
1 participant
@sbrannen