Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail early FactoryBean instantiation for LinkageError #26425

Closed
wants to merge 4 commits into from
Closed

Fail early FactoryBean instantiation for LinkageError #26425

wants to merge 4 commits into from

Commits on Jan 21, 2021

  1. Fail early FactoryBean instantiation for LinkageError

    In 0288878 to resolve gh-22409, a little bug was introduced:
    if there is LinkageError in FactoryBean instantiation, no first exception.
    
    In JVM, if a class cannot be initialized, it acts like this:
    - at the first time, it will show the real reason and stack
    - then, only show "NoClassDefFoundError: Could not initialize class xxx"
    liudongmiao committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    4e54c25 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2021

  1. don't suppress LinkageError during bean creation

    If there is exception in class initializer, jvm acts like this:
    - for the first time, show the real reason and stack
    - then, mark the class in error state, throws only NoClassDefFoundError
    
    This commit don't suppress any LinkageError during bean creation.
    liudongmiao committed Jan 23, 2021
    Configuration menu
    Copy the full SHA
    7579fb8 View commit details
    Browse the repository at this point in the history
  2. don't suppress LinkageError when set property

    If there is exception in class initializer, jvm acts like this:
    - for the first time, show the real reason and stack
    - then, mark the class in error state, throws only NoClassDefFoundError
    
    This commit don't suppress any LinkageError when set property
    liudongmiao committed Jan 23, 2021
    Configuration menu
    Copy the full SHA
    c4186b0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5f6297b View commit details
    Browse the repository at this point in the history