Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add application/vnd.google.protobuf to ProtobufCodecSupport #26487

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Conversation

making
Copy link
Member

@making making commented Feb 1, 2021

While RSocket spec supports application/vnd.google.protobuf as a Well-known MIME Type, Protobuf Codec doesn't.
As a result, Spring RSocket app that has ProtobufDecoder configured can not receive a payload with application/vnd.google.protobuf data mime type.
https://github.com/rsocket/rsocket/blob/master/Extensions/WellKnownMimeTypes.md

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Feb 1, 2021
@bclozel
Copy link
Member

bclozel commented Feb 1, 2021

@making application/vnd.google.protobuf sounds good, but is "application/octet-stream" really necessary? This one might be problematic.

@making
Copy link
Member Author

making commented Feb 1, 2021

I think it's safe to keep it for the backwards compatibility.

@sbrannen sbrannen added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Feb 1, 2021
@sbrannen
Copy link
Member

sbrannen commented Feb 1, 2021

@making application/vnd.google.protobuf sounds good, but is "application/octet-stream" really necessary?

"application/octet-stream" was already there.

@bclozel
Copy link
Member

bclozel commented Feb 1, 2021

Ha, never mind I misread the diff. Thanks!

@rstoyanchev rstoyanchev self-assigned this Feb 2, 2021
@rstoyanchev
Copy link
Contributor

I think this safe to do. It would expand the capability on the decoding side, but on the encoding side we still default to the first one on the list.

@rstoyanchev rstoyanchev added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Feb 2, 2021
@rstoyanchev rstoyanchev added this to the 5.3.4 milestone Feb 2, 2021
@sbrannen sbrannen removed the request for review from sdeleuze February 2, 2021 16:54
@rstoyanchev rstoyanchev merged commit 0575e66 into spring-projects:master Feb 2, 2021
@rstoyanchev rstoyanchev changed the title Add application/vnd.google.protobuf to supported Mime Type of Protobuf Codec Add application/vnd.google.protobuf to ProtobufCodecSupport Feb 2, 2021
@making making deleted the patch-1 branch February 2, 2021 16:56
@rstoyanchev rstoyanchev added type: enhancement A general enhancement and removed type: task A general task labels Feb 2, 2021
This was referenced Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants