Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Eclipse Jetty core HTTP handler adapter #32097

Closed
wants to merge 156 commits into from
Closed

Implement Eclipse Jetty core HTTP handler adapter #32097

wants to merge 156 commits into from

Commits on Feb 6, 2024

  1. Initial boiler plate implementation of JettyCore HttpHandler Adaptor

    @gregw @olamy
    gregw authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    6ff974d View commit details
    Browse the repository at this point in the history

  2. More implementation of the request side

    @gregw @olamy
    gregw authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    db609a7 View commit details
    Browse the repository at this point in the history

  3. Created JettyCoreHttpServer

    @gregw @olamy
    gregw authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    7a23fbf View commit details
    Browse the repository at this point in the history

  4. Created JettyCoreHttpServer

    @gregw @olamy
    gregw authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    418d699 View commit details
    Browse the repository at this point in the history

  5. WIP on tests

    @gregw @olamy
    gregw authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    930d420 View commit details
    Browse the repository at this point in the history

  6. WIP on tests

    @gregw @olamy
    gregw authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    eb38434 View commit details
    Browse the repository at this point in the history

  7. Cleanup start/stop for jetty

    @gregw @olamy
    gregw authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    88e7467 View commit details
    Browse the repository at this point in the history

  8. retainable bytebuffer!

    @gregw @olamy
    gregw authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    c5a327c View commit details
    Browse the repository at this point in the history

  9. Non blocking invocation type

    @gregw @olamy
    gregw authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    49abe72 View commit details
    Browse the repository at this point in the history

  10. split out into separate files

    @gregw @olamy
    gregw authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    6ca453c View commit details
    Browse the repository at this point in the history

  11. minor httpHeader optimizations

    @gregw @olamy
    gregw authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    ea71c61 View commit details
    Browse the repository at this point in the history

  12. since updated with expected release

    @gregw @olamy
    gregw authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    dd72a14 View commit details
    Browse the repository at this point in the history

  13. Initial implementation of the writeWith methods in JettyCoreServerHtt… 

    …pResponse

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @olamy
    lachlan-roberts authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    50e78d3 View commit details
    Browse the repository at this point in the history

  14. Implement the ZeroCopyHttpOutputMessage interface for JettyCoreServer… 

    …HttpResponse

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @olamy
    lachlan-roberts authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    ab844d6 View commit details
    Browse the repository at this point in the history

  15. Add temporary fix for cookies 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @olamy
    lachlan-roberts authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    4cf2b0c View commit details
    Browse the repository at this point in the history

  16. disable setting of the same site cookie attribute to fix test 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @olamy
    lachlan-roberts authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    77772cb View commit details
    Browse the repository at this point in the history

  17. rearrange methods in JettyCoreServerHttpResponse 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @olamy
    lachlan-roberts authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    8617ded View commit details
    Browse the repository at this point in the history

  18. fix issues with cookies, committing response, and with ZeroCopyHttpOu… 

    …tputMessage

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @olamy
    lachlan-roberts authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    375e3b6 View commit details
    Browse the repository at this point in the history

  19. cleanups 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @olamy
    lachlan-roberts authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    0db46f2 View commit details
    Browse the repository at this point in the history

  20. cleanups 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @olamy
    lachlan-roberts authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    2081ae0 View commit details
    Browse the repository at this point in the history

  21. removed TODO

    @gregw @olamy
    gregw authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    855e268 View commit details
    Browse the repository at this point in the history

  22. Reformatted code

    @gregw @olamy
    gregw authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    191853d View commit details
    Browse the repository at this point in the history

  23. Fixed unset response status bug 

    Jetty has an unset response status of 0, this should be converted to 200 for spring.
    @gregw @olamy
    gregw authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    c8a7cc3 View commit details
    Browse the repository at this point in the history

  24. Request header mutation support 

    When mutating the request, a mutable HttpFields instance is created.
    @gregw @olamy
    gregw authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    85bdb2b View commit details
    Browse the repository at this point in the history

  25. Do not use canonical path 

    Spring appears to want the unadulterated raw path complete with parameters etc.
    @gregw @olamy
    gregw authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    39f9ce8 View commit details
    Browse the repository at this point in the history

  26. Track leaks (for now) and retain DataBuffer chunks

    @gregw @olamy
    gregw authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    c46382e View commit details
    Browse the repository at this point in the history

  27. Fixes for Jetty Core WebSocket 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @olamy
    lachlan-roberts authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    72921c0 View commit details
    Browse the repository at this point in the history

  28. Temporary fix for cookies in JettyCoreServerHttpResponse with TODOs 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @olamy
    lachlan-roberts authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    05df5d1 View commit details
    Browse the repository at this point in the history

  29. Do not actually commit response in JettyCoreServerHttpResponse & fix … 

    …cookies

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @olamy
    lachlan-roberts authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    89dbcbf View commit details
    Browse the repository at this point in the history

  30. Add JettyCore upgrade option in HandshakeWebSocketService 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @olamy
    lachlan-roberts authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    654407e View commit details
    Browse the repository at this point in the history

  31. move getNativeRequest/Response to ServerHttpRequest/Response interfaces 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @olamy
    lachlan-roberts authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    802419e View commit details
    Browse the repository at this point in the history

  32. Reformatted code

    @gregw @olamy
    gregw authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    4518138 View commit details
    Browse the repository at this point in the history

  33. WIP on fixing leaks

    @gregw @olamy
    gregw authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    67622d1 View commit details
    Browse the repository at this point in the history

  34. WIP on fixing leaks

    @gregw @olamy
    gregw authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    0530dd7 View commit details
    Browse the repository at this point in the history

  35. WIP on fixing tests

    @gregw @olamy
    gregw authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    a5b7d21 View commit details
    Browse the repository at this point in the history

  36. Updated to jetty 12.0.6

    @gregw @olamy
    gregw authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    f25837c View commit details
    Browse the repository at this point in the history

  37. Move all response cookies to multiMap for possible mutation by spring

    @gregw @olamy
    gregw authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    7cf3214 View commit details
    Browse the repository at this point in the history

  38. Use an atomicReference to release the last used databuffer after onNe… 

    …xt has returned.
    @gregw @olamy
    gregw authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    c8c3734 View commit details
    Browse the repository at this point in the history

  39. less allocations for releasing after onNext

    @gregw @olamy
    gregw authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    74aa6cb View commit details
    Browse the repository at this point in the history

  40. release DataBuffer from the JettyCoreServerHttpResponse 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @olamy
    lachlan-roberts authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    befdde4 View commit details
    Browse the repository at this point in the history

  41. fixed style

    @gregw @olamy
    gregw authored and olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    ee59264 View commit details
    Browse the repository at this point in the history

  42. fix build with jetty 12.0.7-SNAPSHOT 

    Signed-off-by: Olivier Lamy <olamy@apache.org>
    @olamy
    olamy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    bbd2573 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Updated to jetty 12.0.6

    @gregw @lachlan-roberts
    gregw authored and lachlan-roberts committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    b1c778d View commit details
    Browse the repository at this point in the history

  2. Implement a JettyWebSocketSession based on demand. 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts
    lachlan-roberts committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    5f1712d View commit details
    Browse the repository at this point in the history

  3. Add a Jetty implementation of the spring WebSocketClient interface. 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts
    lachlan-roberts committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    700f8e6 View commit details
    Browse the repository at this point in the history

  4. Prevent possible ReadPendingException from multiple demand. 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts
    lachlan-roberts committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    1c7935e View commit details
    Browse the repository at this point in the history

  5. Update the JettyWebSocketHandlerAdapter as a Session.Listener 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts
    lachlan-roberts committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    bbd4e68 View commit details
    Browse the repository at this point in the history

  6. fixes for checkstyle 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts
    lachlan-roberts committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    1f09a94 View commit details
    Browse the repository at this point in the history

  7. Ensure DataBuffer is processed correctly for BINARY messages. 

    Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
    @lachlan-roberts
    lachlan-roberts committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    08e9177 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Wait for close of Session before calling handlerCompletionSink 

    Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
    @lachlan-roberts
    lachlan-roberts committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    26cac28 View commit details
    Browse the repository at this point in the history

  2. fix checkstyle error 

    Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
    @lachlan-roberts
    lachlan-roberts committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    e2b452a View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Merge remote-tracking branch 'webtide/main' into JettyCoreHttpHandler… 

    …Adapter
    @gregw
    gregw committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    b356adf View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Changes from review. 

    Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
    @lachlan-roberts
    lachlan-roberts committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    a0f4fe2 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Merge remote-tracking branch 'webtide/main' into JettyCoreHttpHandler… 

    …Adapter
    @gregw
    gregw committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    0f88d7f View commit details
    Browse the repository at this point in the history

  2. updated to jetty 12.0.7

    @gregw
    gregw committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    65cf738 View commit details
    Browse the repository at this point in the history

  3. updated to jetty 12.0.7

    @gregw
    gregw committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    6e25189 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'webtide/main' into JettyCoreHttpHandler… 

    …Adapter
    @gregw
    gregw committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    8f9d07c View commit details
    Browse the repository at this point in the history

  5. updated to jetty 12.0.7

    @gregw
    gregw committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    34429fe View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. fixed checkstyle

    @gregw
    gregw committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    5d5e46a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into JettyCoreHttpHandlerAdapter

    @gregw
    gregw committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    6187cdf View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Merge branch 'spring-projects:main' into JettyCoreHttpHandlerAdapter

    @gregw
    gregw authored Apr 4, 2024
    Configuration menu
    Copy the full SHA
    d9202dc View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Implement LifeCycle for JettyWebSocketClient 

    Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
    @lachlan-roberts
    lachlan-roberts committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    85505fe View commit details
    Browse the repository at this point in the history

  2. additional changes from review 

    Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
    @lachlan-roberts
    lachlan-roberts committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    cd9063b View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Merge pull request #2 from webtide/JettyCoreHttpHandlerAdapter-WebSocket 

    Update spring Jetty websocket usage
    @lachlan-roberts
    lachlan-roberts authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    e9cb9a9 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Use abstract request/response classes

    @gregw
    gregw committed May 29, 2024
    Configuration menu
    Copy the full SHA
    d6986ee View commit details
    Browse the repository at this point in the history

  2. Suppress NullAway warnings for Jetty WebSocket classes 

    Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
    @lachlan-roberts
    lachlan-roberts committed May 29, 2024
    Configuration menu
    Copy the full SHA
    19215d4 View commit details
    Browse the repository at this point in the history

  3. fix other checkstyle warnings 

    Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
    @lachlan-roberts
    lachlan-roberts committed May 29, 2024
    Configuration menu
    Copy the full SHA
    364183c View commit details
    Browse the repository at this point in the history

  4. backed out abstract response change 

    upgrade jetty
    @gregw
    gregw committed May 29, 2024
    Configuration menu
    Copy the full SHA
    a76465a View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/main' into JettyCoreHttpHandlerA… 

    …dapter

# Conflicts:
#	framework-platform/framework-platform.gradle
    @gregw
    gregw committed May 29, 2024
    Configuration menu
    Copy the full SHA
    c0cdb2b View commit details
    Browse the repository at this point in the history

  6. Steps towards abstract response class

    @gregw
    gregw committed May 29, 2024
    Configuration menu
    Copy the full SHA
    82a18ee View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. add explicit dependency on jetty-websocket-api 

    Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
    @lachlan-roberts
    lachlan-roberts committed May 30, 2024
    Configuration menu
    Copy the full SHA
    fca5d22 View commit details
    Browse the repository at this point in the history

  2. checkstyle

    @gregw
    gregw committed May 30, 2024
    Configuration menu
    Copy the full SHA
    17eb8df View commit details
    Browse the repository at this point in the history

  3. updated response to use the abstract

    @gregw
    gregw committed May 30, 2024
    Configuration menu
    Copy the full SHA
    38e4913 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. updated response to use the abstract

    @gregw
    gregw committed May 31, 2024
    Configuration menu
    Copy the full SHA
    85b4041 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'refs/remotes/webtide/JettyCoreHttpHandl… 

    …erAdapter' into JettyCoreHttpHandlerAdapter
    @gregw
    gregw committed May 31, 2024
    Configuration menu
    Copy the full SHA
    df6ad58 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Initial boiler plate implementation of JettyCore HttpHandler Adaptor

    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    37daa27 View commit details
    Browse the repository at this point in the history

  2. More implementation of the request side

    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    c5b37ba View commit details
    Browse the repository at this point in the history

  3. Created JettyCoreHttpServer

    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    0ea2180 View commit details
    Browse the repository at this point in the history

  4. Created JettyCoreHttpServer

    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    49363c1 View commit details
    Browse the repository at this point in the history

  5. WIP on tests

    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    090c8c4 View commit details
    Browse the repository at this point in the history

  6. WIP on tests

    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    390f52e View commit details
    Browse the repository at this point in the history

  7. Cleanup start/stop for jetty

    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    b884f65 View commit details
    Browse the repository at this point in the history

  8. retainable bytebuffer!

    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    2aedef1 View commit details
    Browse the repository at this point in the history

  9. Non blocking invocation type

    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    4613e8c View commit details
    Browse the repository at this point in the history

  10. split out into separate files

    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    5378423 View commit details
    Browse the repository at this point in the history

  11. minor httpHeader optimizations

    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    f070f90 View commit details
    Browse the repository at this point in the history

  12. since updated with expected release

    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    dc02b28 View commit details
    Browse the repository at this point in the history

  13. Initial implementation of the writeWith methods in JettyCoreServerHtt… 

    …pResponse

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @poutsma
    lachlan-roberts authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    543c30a View commit details
    Browse the repository at this point in the history

  14. Implement the ZeroCopyHttpOutputMessage interface for JettyCoreServer… 

    …HttpResponse

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @poutsma
    lachlan-roberts authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    0ef95af View commit details
    Browse the repository at this point in the history

  15. Add temporary fix for cookies 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @poutsma
    lachlan-roberts authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    4c0d782 View commit details
    Browse the repository at this point in the history

  16. disable setting of the same site cookie attribute to fix test 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @poutsma
    lachlan-roberts authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    c5caff8 View commit details
    Browse the repository at this point in the history

  17. rearrange methods in JettyCoreServerHttpResponse 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @poutsma
    lachlan-roberts authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    8bb9f63 View commit details
    Browse the repository at this point in the history

  18. fix issues with cookies, committing response, and with ZeroCopyHttpOu… 

    …tputMessage

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @poutsma
    lachlan-roberts authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    6311b33 View commit details
    Browse the repository at this point in the history

  19. cleanups 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @poutsma
    lachlan-roberts authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    01bde19 View commit details
    Browse the repository at this point in the history

  20. cleanups 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @poutsma
    lachlan-roberts authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    1c6d8db View commit details
    Browse the repository at this point in the history

  21. removed TODO

    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    071cd55 View commit details
    Browse the repository at this point in the history

  22. Reformatted code

    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    d18b34b View commit details
    Browse the repository at this point in the history

  23. Fixed unset response status bug 

    Jetty has an unset response status of 0, this should be converted to 200 for spring.
    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    6b36d70 View commit details
    Browse the repository at this point in the history

  24. Request header mutation support 

    When mutating the request, a mutable HttpFields instance is created.
    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    d86e795 View commit details
    Browse the repository at this point in the history

  25. Do not use canonical path 

    Spring appears to want the unadulterated raw path complete with parameters etc.
    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    8d64408 View commit details
    Browse the repository at this point in the history

  26. Track leaks (for now) and retain DataBuffer chunks

    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    6c4f7bc View commit details
    Browse the repository at this point in the history

  27. Fixes for Jetty Core WebSocket 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @poutsma
    lachlan-roberts authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    56e933c View commit details
    Browse the repository at this point in the history

  28. Temporary fix for cookies in JettyCoreServerHttpResponse with TODOs 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @poutsma
    lachlan-roberts authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    1bce7b9 View commit details
    Browse the repository at this point in the history

  29. Do not actually commit response in JettyCoreServerHttpResponse & fix … 

    …cookies

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @poutsma
    lachlan-roberts authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    f934d31 View commit details
    Browse the repository at this point in the history

  30. Add JettyCore upgrade option in HandshakeWebSocketService 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @poutsma
    lachlan-roberts authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    d2e152b View commit details
    Browse the repository at this point in the history

  31. move getNativeRequest/Response to ServerHttpRequest/Response interfaces 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @poutsma
    lachlan-roberts authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    014c77c View commit details
    Browse the repository at this point in the history

  32. Reformatted code

    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    cd8bf6a View commit details
    Browse the repository at this point in the history

  33. WIP on fixing leaks

    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    c20b865 View commit details
    Browse the repository at this point in the history

  34. WIP on fixing leaks

    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    a8c9e95 View commit details
    Browse the repository at this point in the history

  35. WIP on fixing tests

    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    c6e322e View commit details
    Browse the repository at this point in the history

  36. Updated to jetty 12.0.6

    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    e830a02 View commit details
    Browse the repository at this point in the history

  37. Move all response cookies to multiMap for possible mutation by spring

    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    14d9a76 View commit details
    Browse the repository at this point in the history

  38. Use an atomicReference to release the last used databuffer after onNe… 

    …xt has returned.
    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    d5ff365 View commit details
    Browse the repository at this point in the history

  39. less allocations for releasing after onNext

    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    8efbc37 View commit details
    Browse the repository at this point in the history

  40. release DataBuffer from the JettyCoreServerHttpResponse 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @poutsma
    lachlan-roberts authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    9a68ff7 View commit details
    Browse the repository at this point in the history

  41. fixed style

    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    011d856 View commit details
    Browse the repository at this point in the history

  42. fix build with jetty 12.0.7-SNAPSHOT 

    Signed-off-by: Olivier Lamy <olamy@apache.org>
    @olamy @poutsma
    olamy authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    5e71a1c View commit details
    Browse the repository at this point in the history

  43. updated to jetty 12.0.7

    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    7cb17ce View commit details
    Browse the repository at this point in the history

  44. updated to jetty 12.0.7

    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    f47baaf View commit details
    Browse the repository at this point in the history

  45. fixed checkstyle

    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    9bba36b View commit details
    Browse the repository at this point in the history

  46. Implement a JettyWebSocketSession based on demand. 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @poutsma
    lachlan-roberts authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    f06131b View commit details
    Browse the repository at this point in the history

  47. Add a Jetty implementation of the spring WebSocketClient interface. 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @poutsma
    lachlan-roberts authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    8cc8b11 View commit details
    Browse the repository at this point in the history

  48. Prevent possible ReadPendingException from multiple demand. 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @poutsma
    lachlan-roberts authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    2b9510d View commit details
    Browse the repository at this point in the history

  49. Update the JettyWebSocketHandlerAdapter as a Session.Listener 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @poutsma
    lachlan-roberts authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    96a8e99 View commit details
    Browse the repository at this point in the history

  50. fixes for checkstyle 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts @poutsma
    lachlan-roberts authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    f195e4e View commit details
    Browse the repository at this point in the history

  51. Ensure DataBuffer is processed correctly for BINARY messages. 

    Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
    @lachlan-roberts @poutsma
    lachlan-roberts authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    7939314 View commit details
    Browse the repository at this point in the history

  52. Wait for close of Session before calling handlerCompletionSink 

    Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
    @lachlan-roberts @poutsma
    lachlan-roberts authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    30a7c41 View commit details
    Browse the repository at this point in the history

  53. fix checkstyle error 

    Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
    @lachlan-roberts @poutsma
    lachlan-roberts authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    7ccb2e1 View commit details
    Browse the repository at this point in the history

  54. Changes from review. 

    Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
    @lachlan-roberts @poutsma
    lachlan-roberts authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    38ef5bb View commit details
    Browse the repository at this point in the history

  55. Implement LifeCycle for JettyWebSocketClient 

    Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
    @lachlan-roberts @poutsma
    lachlan-roberts authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    ea1dd82 View commit details
    Browse the repository at this point in the history

  56. additional changes from review 

    Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
    @lachlan-roberts @poutsma
    lachlan-roberts authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    e32983b View commit details
    Browse the repository at this point in the history

  57. Use abstract request/response classes

    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    077b60f View commit details
    Browse the repository at this point in the history

  58. Suppress NullAway warnings for Jetty WebSocket classes 

    Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
    @lachlan-roberts @poutsma
    lachlan-roberts authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    fa5f800 View commit details
    Browse the repository at this point in the history

  59. fix other checkstyle warnings 

    Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
    @lachlan-roberts @poutsma
    lachlan-roberts authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    442f11c View commit details
    Browse the repository at this point in the history

  60. backed out abstract response change 

    upgrade jetty
    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    bd25bd7 View commit details
    Browse the repository at this point in the history

  61. Steps towards abstract response class

    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    3785321 View commit details
    Browse the repository at this point in the history

  62. checkstyle

    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    d8eb3fa View commit details
    Browse the repository at this point in the history

  63. updated response to use the abstract

    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    c6b1914 View commit details
    Browse the repository at this point in the history

  64. updated response to use the abstract

    @gregw @poutsma
    gregw authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    a2420fc View commit details
    Browse the repository at this point in the history

  65. add explicit dependency on jetty-websocket-api 

    Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
    @lachlan-roberts @poutsma
    lachlan-roberts authored and poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    5fbf83c View commit details
    Browse the repository at this point in the history

  66. Polishing

    @poutsma
    poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    9b7a2f4 View commit details
    Browse the repository at this point in the history

  67. Replace flatMap(...,1) with concatMap

    @poutsma
    poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    b8d208d View commit details
    Browse the repository at this point in the history

  68. Make copy of headers map

    @poutsma
    poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    db82c22 View commit details
    Browse the repository at this point in the history

  69. Introduce JettyDataBuffer

    @poutsma
    poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    16af65a View commit details
    Browse the repository at this point in the history

  70. Polish JettyDataBuffer

    @poutsma
    poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    6c48a83 View commit details
    Browse the repository at this point in the history

  71. Polishing

    @poutsma
    poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    feef4a7 View commit details
    Browse the repository at this point in the history

  72. Polishing

    @poutsma
    poutsma committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    d00ed1e View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Merge remote-tracking branch 'poutsma/spring-projectsgh-32097' into J… 

    …ettyCoreHttpHandlerAdapter

# Conflicts:
#	spring-web/src/main/java/org/springframework/http/server/reactive/DefaultServerHttpRequestBuilder.java
#	spring-web/src/main/java/org/springframework/http/server/reactive/JettyCoreHttpHandlerAdapter.java
#	spring-web/src/main/java/org/springframework/http/server/reactive/JettyCoreServerHttpRequest.java
#	spring-web/src/main/java/org/springframework/http/server/reactive/JettyCoreServerHttpResponse.java
#	spring-webflux/src/main/java/org/springframework/web/reactive/socket/adapter/JettyWebSocketHandlerAdapter.java
#	spring-webflux/src/main/java/org/springframework/web/reactive/socket/adapter/JettyWebSocketSession.java
#	spring-websocket/src/main/java/org/springframework/web/socket/adapter/jetty/JettyWebSocketHandlerAdapter.java
    @gregw
    gregw committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    1f2f0af View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'poutsma/spring-projectsgh-32097' into J… 

    …ettyCoreHttpHandlerAdapter

# Conflicts:
#	spring-web/src/main/java/org/springframework/http/server/reactive/DefaultServerHttpRequestBuilder.java
#	spring-web/src/main/java/org/springframework/http/server/reactive/JettyCoreHttpHandlerAdapter.java
#	spring-web/src/main/java/org/springframework/http/server/reactive/JettyCoreServerHttpRequest.java
#	spring-web/src/main/java/org/springframework/http/server/reactive/JettyCoreServerHttpResponse.java
#	spring-webflux/src/main/java/org/springframework/web/reactive/socket/adapter/JettyWebSocketHandlerAdapter.java
#	spring-webflux/src/main/java/org/springframework/web/reactive/socket/adapter/JettyWebSocketSession.java
#	spring-websocket/src/main/java/org/springframework/web/socket/adapter/jetty/JettyWebSocketHandlerAdapter.java
    @gregw
    gregw committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    08ce47f View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into JettyCoreHttpHandlerA… 

    …dapter
    @gregw
    gregw committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    8753907 View commit details
    Browse the repository at this point in the history

  4. addExact

    @gregw
    gregw committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    260da30 View commit details
    Browse the repository at this point in the history

  5. doCommit not required

    @gregw
    gregw committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    d415757 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2024

  1. PR spring-projects#32097 - changes to address reviews for websocket 

    Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
    @lachlan-roberts
    lachlan-roberts committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    0b4b65f View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. doCommit not required

    @gregw
    gregw committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    5dd2538 View commit details
    Browse the repository at this point in the history

  2. fix checkstyle errors 

    Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
    @lachlan-roberts
    lachlan-roberts committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    6380d3a View commit details
    Browse the repository at this point in the history

  3. fix failure for CookieIntegrationTests.partitionedAttributeTest 

    Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
    @lachlan-roberts
    lachlan-roberts committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    ca25b6c View commit details
    Browse the repository at this point in the history