Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new configuration infrastructure on MappingJackson2MessageConverter / Jackson2CodecSupport #1453

Closed
odrotbohm opened this issue Feb 10, 2021 · 0 comments
Closed

Use new configuration infrastructure on MappingJackson2MessageConverter / Jackson2CodecSupport #1453

odrotbohm opened this issue Feb 10, 2021 · 0 comments
Assignees
@odrotbohm
Labels
in: configuration Configuration and setup in: mediatypes Media type related functionality type: enhancement
Milestone
1.3 M2

Comments

@odrotbohm
Copy link
Member

The current converter and and codec arrangement leaves Spring HATEOAS subject to invalid response type selection in certain configuration and request scenarios (see spring-projects/spring-framework#26212 for details). Spring Framework 5.3.4 introduces advanced configuration APIs on MappingJackson2MessageConverter and its reactive sibling. We should move to that to avoid the problem described in the linked ticket.
@odrotbohm odrotbohm added type: enhancement in: mediatypes Media type related functionality in: configuration Configuration and setup labels Feb 10, 2021
@odrotbohm odrotbohm added this to the 1.3 M2 milestone Feb 10, 2021
@odrotbohm odrotbohm self-assigned this Feb 10, 2021
@odrotbohm odrotbohm changed the title Use new configuration infrastructure on MappingJackson2MessageConverter / Jackson2CodecSupport. Use new configuration infrastructure on MappingJackson2MessageConverter / Jackson2CodecSupport Feb 10, 2021
odrotbohm added a commit that referenced this issue Feb 10, 2021
@odrotbohm
#1453 - Switch to new converter / codec registration APIs in Spring 5…
c561822 
….3.4.

Changed the configuration of media type specific representation model rendering to rather use the existing MappingJackson2JsonConverter than registering custom HttpMessageConverters ourselves. The same applies to codecs in WebFlux.

Added HypermediaMappingInformationComparator to be able to sort HypermediaMappingInformation instances by their corresponding media type configuration on @EnableHypermediaSupport.
odrotbohm added a commit that referenced this issue Feb 11, 2021
@odrotbohm
#1453 - Make sure we only extend the default MappingJackson2HttpMessa…
0aae59a 
…geConverter.

This is to make sure the custom converters registered by Spring Data REST, which all extend MJ2HMC, do not get the general customizations added as they otherwise trump the explicit configuration that Spring Data REST sets up.
@BasicWolf BasicWolf mentioned this issue May 24, 2021
Closed
@bclozel bclozel mentioned this issue Jun 8, 2021
Closed
@rstoyanchev rstoyanchev mentioned this issue Oct 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
in: configuration Configuration and setup in: mediatypes Media type related functionality type: enhancement
Projects
None yet
Milestone
1.3 M2
Development

No branches or pull requests
1 participant
@odrotbohm