Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude Spring AOT classes from architecture verification #406

Closed
odrotbohm opened this issue Dec 6, 2023 · 2 comments
Closed

Exclude Spring AOT classes from architecture verification #406

odrotbohm opened this issue Dec 6, 2023 · 2 comments
Assignees
@odrotbohm
Labels
in: core Core module meta model type: improvement Minor improvements
Milestone
1.2 M1

Comments

@odrotbohm
Copy link
Member

Side track of #401. Also, spring-projects/spring-framework#30824.
@odrotbohm odrotbohm added in: core Core module meta model type: improvement Minor improvements labels Dec 6, 2023
@odrotbohm odrotbohm added this to the 1.2 M1 milestone Dec 6, 2023
@odrotbohm odrotbohm self-assigned this Dec 6, 2023
This was referenced Dec 6, 2023
Closed
Closed
odrotbohm added a commit that referenced this issue Dec 6, 2023
@odrotbohm
GH-406 - Ignore Spring AOT generated types in architecture model.
e7b531e 
We now explicitly exclude classes generated by Spring AOT in the architectural model. For technical reasons, they might introduce dependencies to application components considered module internals otherwise. Also, proxies generated do not need to be considered either.
@snicoll
Copy link
Member

snicoll commented Dec 8, 2023

This could be reopened to use the @Generated annotation that will be available as of 6.1.2 perhaps?

@odrotbohm
Copy link
Member Author

I'll definitely switch to the new annotation for the 1.2 branch. Thanks for the quick turnaround!

odrotbohm added a commit that referenced this issue Dec 9, 2023
@odrotbohm
GH-406 - Improving the detection of Spring AOT classes.
c1f5630 
We now inspect the classes for the newly introduced Spring AOT @generated annotation instead of a name containing a double underscore.
odrotbohm added a commit that referenced this issue Jan 17, 2024
@odrotbohm
GH-406 - Improve detection of AOT types generated by Spring.
e7fa750 
We now guard the annotation predicate for @generated behind a classpath check to avoid a NoClassDefFoundError on previous versions of Spring Framework.
odrotbohm added a commit that referenced this issue Jan 17, 2024
@odrotbohm
GH-406 - Improve detection of AOT types generated by Spring.
48aa0b2 
We now guard the annotation predicate for @generated behind a classpath check to avoid a NoClassDefFoundError on previous versions of Spring Framework.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
in: core Core module meta model type: improvement Minor improvements
Projects
None yet
Milestone
1.2 M1
Development

No branches or pull requests
2 participants
@odrotbohm @snicoll