Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AuthoritiesAuthorizationManager in Jsr250AuthorizationManager #12782

Closed
jzheaux opened this issue Feb 24, 2023 · 1 comment · Fixed by #13224
Closed

Use AuthoritiesAuthorizationManager in Jsr250AuthorizationManager #12782

jzheaux opened this issue Feb 24, 2023 · 1 comment · Fixed by #13224
Labels
in: core An issue in spring-security-core status: ideal-for-contribution An issue that we actively are looking for someone to help us with type: enhancement A general enhancement

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Feb 24, 2023 •
edited
Loading

This would provide the same externalization benefit for @RolesAllowed as @Secured. It would also simplify configuring a RoleHierarchy for @RolesAllowed.

@PermitAll and @DenyAll will require different treatment since they do not imply any individual authorities and would thus not invoke AuthoritiesAuthorizationManager.
@jzheaux jzheaux added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement in: core An issue in spring-security-core status: ideal-for-contribution An issue that we actively are looking for someone to help us with and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 24, 2023
@kandaguru17
Copy link
Contributor

Can I work on this one? @jzheaux
I may have a PR for this one

@kandaguru17 kandaguru17 mentioned this issue May 25, 2023
Merged
kandaguru17 added a commit to kandaguru17/spring-security that referenced this issue Jun 1, 2023
@kandaguru17
Use AuthoritiesAuthorizationManager in Jsr250AuthorizationManager
bedd419 
Closes spring-projectsgh-12782
jzheaux pushed a commit that referenced this issue Jun 22, 2023
@kandaguru17 @jzheaux
Use AuthoritiesAuthorizationManager in Jsr250AuthorizationManager
fa2bc74 
Closes gh-12782
jzheaux added a commit that referenced this issue Jun 22, 2023
@jzheaux
Update JavaDoc
3391859 
Issue gh-12782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: core An issue in spring-security-core status: ideal-for-contribution An issue that we actively are looking for someone to help us with type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use AuthoritiesAuthorizationManager in Jsr250AuthorizationManager kandaguru17/spring-security
2 participants
@jzheaux @kandaguru17