Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Servlet 3.0 Support in AbstractRequestMatcherRegistry #6264

Closed
jzheaux opened this issue Dec 7, 2018 · 3 comments
Closed

Remove Servlet 3.0 Support in AbstractRequestMatcherRegistry #6264

jzheaux opened this issue Dec 7, 2018 · 3 comments
Assignees
@jzheaux @farooqkhan003
Labels
in: web An issue in web modules (web, webmvc) status: first-timers-only An issue that can only be worked on by brand new contributors type: enhancement A general enhancement
Milestone
5.2.0.M1

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Dec 7, 2018 •
edited
Loading

Related to #6220

AbstractRequestMatcherRegistry checks first to make sure that the class javax.servlet.ServletRegistration is present.

Since Spring Framework 5.x increases it's Servlet Spec baseline to 3.1, this check is no longer necessary, and the class can assume its availability.

The task here, then, is to remove the check. Since isServlet30 is effectively always true now, the class should now always postProcess the ObjectPostProcessor instead of conditionally.
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement labels Dec 7, 2018
@jzheaux jzheaux added this to the 5.2.0.M1 milestone Dec 7, 2018
@jzheaux jzheaux mentioned this issue Dec 7, 2018
Closed
7 tasks
@jzheaux jzheaux changed the title Remove Servlet 2.5 Support in AbstractRequestMatcherRegistry Remove Servlet 3.0 Support in AbstractRequestMatcherRegistry Dec 7, 2018
@jzheaux jzheaux added the status: first-timers-only An issue that can only be worked on by brand new contributors label Dec 14, 2018
@farooqkhan003
Copy link
Contributor

@jzheaux can I pick this?

@jzheaux
Copy link
Contributor Author

jzheaux commented Dec 20, 2018

It's yours, @farooqkhan003!

@farooqkhan003 farooqkhan003 mentioned this issue Dec 24, 2018
Merged
@jzheaux
Copy link
Contributor Author

jzheaux commented Jan 4, 2019

Fixed via 3b4ee1f

@jzheaux jzheaux closed this as completed Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

@farooqkhan003 farooqkhan003

Labels
in: web An issue in web modules (web, webmvc) status: first-timers-only An issue that can only be worked on by brand new contributors type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.0.M1
Development

No branches or pull requests
2 participants
@jzheaux @farooqkhan003