Removed isServlet30 check #6331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jzheaux I have made the PR, can you please review. |
|
@farooqkhan003, this looks great, thank you! Would you please squash your commits, in preparation for merging? |
farooqkhan003
force-pushed
the
Issue-6264
branch
from
b325027
to
3b4ee1f
Compare
|
Thanks, @farooqkhan003! This is now merged into And welcome to contributing to Spring Security! Please take a look at the issues list to look for other ways to contribute. Issues tagged with |
jzheaux
added
status: duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since isServlet30 is effectively always true now, so removed the check.
Github issue #6264