Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a Map-based AuthenticationManagerResolver #6762

Closed
jzheaux opened this issue Apr 9, 2019 · 2 comments · Fixed by #7366
Closed

Introduce a Map-based AuthenticationManagerResolver #6762

jzheaux opened this issue Apr 9, 2019 · 2 comments · Fixed by #7366
Assignees
@jzheaux
Labels
in: core An issue in spring-security-core type: enhancement A general enhancement
Milestone
5.7.0-M2

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Apr 9, 2019 •
edited
Loading

Recently, #6722 introduced a contract for resolving an AuthenticationManager via some context, like a request.

A natural implementation for this would be one that contained a Map<RequestMatcher, AuthenticationManager> and selected the AuthenticationManager from the configured Map.

This aligns with other request-matching API implementations like DelegatingAuthenticationEntryPoint and RequestMatcherDelegatingAccessDeniedHandler.
@jzheaux jzheaux added in: core An issue in spring-security-core New Feature labels Apr 9, 2019
@jzheaux jzheaux added this to the 5.2.0.M2 milestone Apr 9, 2019
@jzheaux jzheaux self-assigned this Apr 9, 2019
@clevertension
Copy link
Contributor

i can't find AuthenticationMatcher in the repo, do you mean AuthenticationManager?

@jzheaux
Copy link
Contributor Author

jzheaux commented Apr 10, 2019

Good catch, @clevertension. I've updated the description.

@jgrandja jgrandja modified the milestones: 5.2.0.M2, 5.2.0.RC1 Apr 15, 2019
@rwinch rwinch added type: enhancement A general enhancement and removed New Feature labels May 3, 2019
@eleftherias eleftherias modified the milestones: 5.2.0.M3, 5.2.0.RC1 Jun 14, 2019
@jzheaux jzheaux modified the milestones: 5.2.0.M4, 5.2.0.RC1 Aug 5, 2019
jzheaux added a commit to jzheaux/spring-security that referenced this issue Sep 5, 2019
@jzheaux
Add Request AuthenticationManagerResolvers
2a3f03a 
Fixes spring-projectsgh-6762
@jzheaux jzheaux mentioned this issue Sep 5, 2019
Merged
@jzheaux jzheaux modified the milestones: 5.2.0.RC1, 5.2.0 Sep 5, 2019
@jzheaux jzheaux modified the milestones: 5.2.0, 5.3.x Sep 30, 2019
jzheaux added a commit that referenced this issue Dec 16, 2021
@jzheaux
Add Request-based AuthenticationManagerResolvers
a26521c 
Closes gh-6762
jzheaux added a commit that referenced this issue Jan 25, 2022
@jzheaux
Add Request-based AuthenticationManagerResolvers
89ecad1 
Closes gh-6762
jzheaux added a commit that referenced this issue Jan 26, 2022
@jzheaux
Add Request-based AuthenticationManagerResolvers
9baf113 
Closes gh-6762
@jzheaux jzheaux modified the milestones: 5.3.x, 5.7.0-M2 Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: core An issue in spring-security-core type: enhancement A general enhancement
Projects
None yet
Milestone
5.7.0-M2
Development

Successfully merging a pull request may close this issue.

Add Request AuthenticationManagerResolvers jzheaux/spring-security
5 participants
@clevertension @rwinch @jzheaux @eleftherias @jgrandja