Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

authorization_code grant should use same ServerRequestCache #8536

Closed
jgrandja opened this issue May 15, 2020 · 6 comments
Closed

authorization_code grant should use same ServerRequestCache #8536

jgrandja opened this issue May 15, 2020 · 6 comments
Assignees
@parikshitdutta
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Milestone
5.4.0-M2

Comments

@jgrandja
Copy link
Contributor

jgrandja commented May 15, 2020 •
edited
Loading

ServerHttpSecurity.OAuth2ClientSpec.configure() registers OAuth2AuthorizationRequestRedirectWebFilter and OAuth2AuthorizationCodeGrantWebFilter for the authorization_code grant flow. However, these WebFilter 's do not share a ServerRequestCache.

We should apply the necessary changes so that the configured ServerRequestCache is used by both WebFilter 's.

Related #8120
@jgrandja jgrandja added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: ideal-for-contribution An issue that we actively are looking for someone to help us with and removed status: waiting-for-triage An issue we've not yet triaged labels May 15, 2020
@jgrandja jgrandja added this to the 5.4.x milestone May 15, 2020
@jgrandja jgrandja mentioned this issue May 15, 2020
Closed
@parikshitdutta
Copy link
Contributor

Hi @jgrandja, can I look into it as well?

@jgrandja
Copy link
Contributor Author

Thanks @parikshitdutta. The issue is yours.

@jgrandja jgrandja removed the status: ideal-for-contribution An issue that we actively are looking for someone to help us with label May 16, 2020
@parikshitdutta parikshitdutta mentioned this issue May 23, 2020
Closed
@parikshitdutta
Copy link
Contributor

Hi @jgrandja, regret taking more time, super cyclone massacred our place. Anyways, please have a look at PR #8587. I will look forward to your feedback.

Thank you.

@jgrandja
Copy link
Contributor Author

I'm really sorry to hear this @parikshitdutta. I hope you and your family are ok? There is no rush for this feature as it's scheduled for 5.4, which is being released early Sep. I will review later this week. Take care of yourself and family.

@parikshitdutta
Copy link
Contributor

Hi @jgrandja, We are blessed to be safe and secure, but it has devastated our place. Things are getting back to normal. Thanks for asking and caring for us.

I will look forward to your feedback as you finish reviewing changes. On a separate note, is there a way, I can get used to the release calendar and planned features for forthcoming releases?

@jgrandja
Copy link
Contributor Author

Hey @parikshitdutta - you can see the scheduled releases here.

I'm glad to hear things are getting back to normal. I wish you and your family luck.

@jgrandja jgrandja modified the milestones: 5.4.x, 5.4.0-M2 Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parikshitdutta parikshitdutta

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
None yet
Milestone
5.4.0-M2
2 participants
@parikshitdutta @jgrandja