Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ServerRequestCache setter in OAuth2AuthorizationCodeGrantWebFilter #8587

Closed
wants to merge 1 commit into from
Closed

Add ServerRequestCache setter in OAuth2AuthorizationCodeGrantWebFilter #8587

wants to merge 1 commit into from

Conversation

parikshitdutta
Copy link
Contributor

@parikshitdutta parikshitdutta commented May 23, 2020 •
edited
Loading

  • added setter to make ServerRequestCache injectable
  • added respective test to validate serverRequestCache can not be set to null
  • added test that asserts the supplied ServerRequestCache is actually used
  • updated ServerHttpSecurity.OAuth2ClientSpec to set the configured requestCache
  • updated tests in OAuth2ClientSpecTests to verify provided ServerRequestCache in OAuth2ClientSpec is used as custom configuration
  • updated tests in OAuth2ClientSpecTests to verify provided ServerRequestCache in OAuth2ClientSpec is used as custom lambda configuration

closes gh-8536 [#8536]

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 23, 2020
@parikshitdutta parikshitdutta mentioned this pull request May 23, 2020
Closed
@jgrandja jgrandja added this to the 5.4.0-M2 milestone Jun 3, 2020
@jgrandja jgrandja added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 3, 2020
@jgrandja
Copy link
Contributor

jgrandja commented Jun 3, 2020

Thanks for the PR @parikshitdutta. This is now in master.
Hope you and your family are doing better.

@jgrandja jgrandja closed this Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jgrandja jgrandja

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
5.4.0-M2
Development

Successfully merging this pull request may close these issues.

authorization_code grant should use same ServerRequestCache
3 participants
@parikshitdutta @jgrandja @spring-projects-issues