Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oauth2Client Test Support should not require an HttpSessionOAuth2AuthorizedClientRepository #8603

Closed
jzheaux opened this issue May 27, 2020 · 0 comments
Closed

oauth2Client Test Support should not require an HttpSessionOAuth2AuthorizedClientRepository #8603

jzheaux opened this issue May 27, 2020 · 0 comments
Assignees
@jzheaux
Labels
in: test An issue in spring-security-test type: enhancement A general enhancement
Milestone
5.4.0-M2

Comments

@jzheaux
Copy link
Contributor

jzheaux commented May 27, 2020

Expected Behavior

No extra OAuth2AuthorizedClientRepository should be required for oauth2Client test support to work with @RegisteredOAuth2AuthorizedClient.

Current Behavior

For oauth2Client() test support, and by association oauth2Login and oidcLogin, require that the OAuth2AuthorizedClientRepository in the application context be of type HttpSessionOAuth2AuthorizedClientRepository to work with @RegisteredOAuth2AuthorizedClient.
@jzheaux jzheaux added in: test An issue in spring-security-test type: enhancement A general enhancement labels May 27, 2020
@jzheaux jzheaux added this to the 5.4.0-M2 milestone May 27, 2020
@jzheaux jzheaux self-assigned this May 27, 2020
jzheaux added a commit to jzheaux/spring-security that referenced this issue May 27, 2020
@jzheaux
Inject TestOAuth2AuthorizedClientRepository
c21cf8e 
Fixes spring-projectsgh-8603
jzheaux added a commit to jzheaux/spring-security that referenced this issue May 27, 2020
@jzheaux
Remove Unneeded OAuth2AuthorizedClientRepository
3e6cd45 
Issue spring-projectsgh-8603
jzheaux added a commit to jzheaux/spring-security that referenced this issue May 27, 2020
@jzheaux
Update OAuth 2.0 Client Testing Docs
3e1e07d 
Issue spring-projectsgh-8603
jzheaux added a commit that referenced this issue May 28, 2020
@jzheaux
Remove Unneeded OAuth2AuthorizedClientRepository
8d84bc5 
Issue gh-8603
jzheaux added a commit that referenced this issue May 28, 2020
@jzheaux
Update OAuth 2.0 Client Testing Docs
da05543 
Issue gh-8603
@jzheaux jzheaux mentioned this issue May 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: test An issue in spring-security-test type: enhancement A general enhancement
Projects
None yet
Milestone
5.4.0-M2
Development

No branches or pull requests
1 participant
@jzheaux