Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LDAP Integration Tests Should Use Random Port #8762

Closed
jzheaux opened this issue Jun 25, 2020 · 0 comments
Closed

LDAP Integration Tests Should Use Random Port #8762

jzheaux opened this issue Jun 25, 2020 · 0 comments
Assignees
@jzheaux
Labels
in: ldap An issue in spring-security-ldap type: enhancement A general enhancement
Milestone
5.4.0-M2

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Jun 25, 2020

Expected Behavior

The integration tests in spring-security-ldap use a random port to prevent collisions

Current Behavior

The ApacheDsContainerConfig uses the default port, which is 55389. With concurrent tests, this increases the likelihood of a collision.

Context

The builds fail more often when LDAP tests use ApacheDsContainer with the default port due to port collisions.
@jzheaux jzheaux added in: ldap An issue in spring-security-ldap type: enhancement A general enhancement labels Jun 25, 2020
@jzheaux jzheaux added this to the 5.4.0-M2 milestone Jun 25, 2020
@jzheaux jzheaux self-assigned this Jun 25, 2020
jzheaux added a commit that referenced this issue Sep 26, 2020
@jzheaux
Set LDAP Samples to Use Zero Port
c0378b9 
Issue gh-8762
@jgrandja jgrandja mentioned this issue Feb 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: ldap An issue in spring-security-ldap type: enhancement A general enhancement
Projects
None yet
Milestone
5.4.0-M2
Development

No branches or pull requests
1 participant
@jzheaux