Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up jBCrypt and include its tests. #13

Closed
wants to merge 1 commit into from
Closed

Clean up jBCrypt and include its tests. #13

wants to merge 1 commit into from

Conversation

josephw
Copy link
Contributor

@josephw josephw commented Jun 30, 2012

  • Synchronise jBCrypt with josephw/jBCrypt.
  • Include fixes from esamson and cleanup by Javafueled.
  • Disable test output for running in the Spring Security build.

@josephw
SEC-1990: Clean up jBCrypt and include its tests.
8d24ebc 
Merge in changes from jBCrypt.
- Use a ByteArrayOutputStream to cache bytes.
- Pass a StringBuilder into encode_base64.
- Refactor string comparison into its own method.
- General clean up.
@rwinch
Copy link
Member

rwinch commented Jul 5, 2012

Thank you for your contribution. The submitted changes have been pushed into master.

@rwinch rwinch closed this Jul 5, 2012
@spring-projects-issues spring-projects-issues mentioned this pull request Feb 5, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephw @rwinch