Resolve The matchingRequestParameterName From The Query String #13817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcusdacoregio
added
in: web
rwinch
requested changes
Sep 14, 2023
| @@ -100,8 +102,9 @@ public void removeRequest(HttpServletRequest currentRequest, HttpServletResponse | |||
|
|
|||
| @Override | |||
| public HttpServletRequest getMatchingRequest(HttpServletRequest request, HttpServletResponse response) { | |||
| if (this.matchingRequestParameterName != null | |||
| && request.getParameter(this.matchingRequestParameterName) == null) { | |||
| MultiValueMap<String, String> queryParams = UriComponentsBuilder | |||
There was a problem hiding this comment.
While this works, it is not optimal. If this.matchingRequestParameterName is null, then the parsing of the query parameters should not be done because it is unnecessary work.
marcusdacoregio
force-pushed
the
gh-13731
branch
from
53607e0
to
8ff0473
Compare
Prior to this commit, the ServletRequest#getParameter method was used in order to verify if the matchingRequestParameterName was present in the request. That method has some side effects like interfering in the execution of the ServletRequest#getInputStream and ServletRequest#getReader method when the request is an HTTP POST (if those methods are invoked after getParameter, or vice-versa, the content won't be available). This commit makes that we only use the query string to check for the parameter, avoiding draining the request's input stream. Closes spring-projectsgh-13731
marcusdacoregio
force-pushed
the
gh-13731
branch
from
8ff0473
to
6cf03ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
ServletRequest#getParametermethod was used in order to verify if thematchingRequestParameterNamewas present in the request. That method has some side effects like interfering in the execution of theServletRequest#getInputStreamandServletRequest#getReadermethod when the request is an HTTP POST (if those methods are invoked after getParameter, or vice-versa, the content won't be available). This commit makes that we only use the query string to check for the parameter, avoiding draining the request's input stream.Closes gh-13731